LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-17 09:20:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Generate all spec tests, even ones that aren't valid modules

Browse Source 
`wasm-as` will do some semantic analysis on the modules, which is not
something we're looking for here.
Instead, use `wat2wasm` to generate the exact module.
This commit is contained in:
Ali Mohammad Pur 2021-06-21 21:04:15 +04:30 committed by Ali Mohammad Pur
parent c4b82ace74
commit 79d4913f76
Notes: sideshowbarker 2024-07-18 11:56:51 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/79d4913f764
Pull-request: https://github.com/SerenityOS/serenity/pull/8180
Reviewed-by: https://github.com/linusg
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/cmake.yml vendored
View File

@ -196,15 +196,15 @@ jobs:
run: |
sudo apt-get purge -y clang-11
sudo apt-get update
sudo apt-get install ninja-build binaryen
sudo apt-get install ninja-build wabt
sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-12 100
sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-12 100
if: ${{ runner.os == 'Linux' }}
- name: Install macOS dependencies
run: brew install ninja binaryen
run: brew install ninja wabt
if: ${{ runner.os == 'macOS' }}
- name: Check versions
run: set +e; clang --version; clang++ --version; ninja --version; wasm-as --version
run: set +e; clang --version; clang++ --version; ninja --version; wat2wasm --version
# === PREPARE FOR BUILDING ===

2
Meta/generate-libwasm-spec-test.py
View File

@ -380,7 +380,7 @@ def main():
with NamedTemporaryFile("w+") as temp:
temp.write(mod[1])
temp.flush()
rc = call(["wasm-as", "-n", "-all", temp.name, "-o", outpath])
rc = call(["wat2wasm", temp.name, "-o", outpath])
if rc != 0:
print("Failed to compile", name, "module index", index, "skipping that test", file=stderr)
continue