LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make BrowsingContextGroup store Page member as NonnullGCPtr

Browse Source 
No need to use WeakPtr anymore.
This commit is contained in:
Andreas Kling 2023-06-26 06:56:54 +02:00
parent 289ea2db9c
commit 7c926d04b7
Notes: sideshowbarker 2024-07-17 00:53:02 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/7c926d04b7
Pull-request: https://github.com/SerenityOS/serenity/pull/22142
Issue: https://github.com/SerenityOS/serenity/issues/22091
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp
View File

@ -34,6 +34,7 @@ BrowsingContextGroup::~BrowsingContextGroup()
void BrowsingContextGroup::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_page);
for (auto& context : m_browsing_context_set)
visitor.visit(context);
}

2
Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h
View File

@ -43,7 +43,7 @@ private:
// https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-group-set
OrderedHashTable<JS::NonnullGCPtr<BrowsingContext>> m_browsing_context_set;
WeakPtr<Page> m_page;
JS::NonnullGCPtr<Page> m_page;
};
}