LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 18:37:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Optimize & Bring String.prototype.repeat closer to the spec

Browse Source 
Specifically, we immediately return an empty string when `this` is an
empty string, instead of wasting time in a loop doing nothing N times.
This commit is contained in:
Idan Horowitz 2021-06-30 15:19:38 +03:00 committed by Linus Groh
parent 5f09d78b9d
commit 7d055dd039
Notes: sideshowbarker 2024-07-18 11:12:52 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/7d055dd0394
Pull-request: https://github.com/SerenityOS/serenity/pull/8334
Reviewed-by: https://github.com/linusg ✅
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Userland/Libraries/LibJS/Runtime/StringPrototype.cpp
View File

@ -167,21 +167,30 @@ JS_DEFINE_NATIVE_FUNCTION(StringPrototype::repeat)
auto string = ak_string_from(vm, global_object);
if (!string.has_value())
return {};
if (!vm.argument_count())
return js_string(vm, String::empty());
auto count = vm.argument(0).to_integer_or_infinity(global_object);
auto n = vm.argument(0).to_integer_or_infinity(global_object);
if (vm.exception())
return {};
if (count < 0) {
if (n < 0) {
vm.throw_exception<RangeError>(global_object, ErrorType::StringRepeatCountMustBe, "positive");
return {};
}
if (Value(count).is_infinity()) {
if (Value(n).is_positive_infinity()) {
vm.throw_exception<RangeError>(global_object, ErrorType::StringRepeatCountMustBe, "finite");
return {};
}
if (n == 0)
return js_string(vm, String::empty());
// NOTE: This is an optimization, it is not required by the specification but it produces equivalent behaviour
if (string->is_empty())
return js_string(vm, String::empty());
StringBuilder builder;
for (size_t i = 0; i < count; ++i)
for (size_t i = 0; i < n; ++i)
builder.append(*string);
return js_string(vm, builder.to_string());
}