LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Check correct activation (spec fix)

Browse Source 
See:
- https://github.com/whatwg/html/commit/d28284f
This commit is contained in:
Jamie Mansfield 2024-05-25 14:27:29 +01:00 committed by Andrew Kaster
parent 34b2a4f7ca
commit 7da449ce01
Notes: sideshowbarker 2024-07-16 23:08:48 +09:00 
Author: https://github.com/jamierocks
Commit: https://github.com/SerenityOS/serenity/commit/7da449ce01
Pull-request: https://github.com/SerenityOS/serenity/pull/24437
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/mattco98
Reviewed-by: https://github.com/tcl3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Navigation.cpp
View File

@ -1000,11 +1000,11 @@ bool Navigation::inner_navigate_event_firing_algorithm(
// 10. Let traverseCanBeCanceled be true if all of the following are true:
// - navigable is a top-level traversable;
// - destination's is same document is true; and
// - either userInvolvement is not "browser UI", or navigation's relevant global object has transient activation.
// - either userInvolvement is not "browser UI", or navigation's relevant global object has history-action activation.
// Otherwise, let it be false.
bool const traverse_can_be_canceled = navigable->is_top_level_traversable()
&& destination->same_document()
&& (user_involvement != UserNavigationInvolvement::BrowserUI || relevant_global_object.has_transient_activation());
&& (user_involvement != UserNavigationInvolvement::BrowserUI || relevant_global_object.has_history_action_activation());
// FIXME: Fix spec grammaro, extra 'the -> set'
// 11. If either: