Kernel: Encapsulate assignment of socket origin/acceptor credentials

This commit is contained in:
Andreas Kling 2021-08-29 01:30:05 +02:00
parent 242063866f
commit 7f96288535
Notes: sideshowbarker 2024-07-18 05:06:52 +09:00
3 changed files with 16 additions and 6 deletions

View File

@ -62,9 +62,7 @@ KResultOr<SocketPair> LocalSocket::create_connected_pair(int type)
socket->m_address.sun_family = AF_LOCAL;
memcpy(socket->m_address.sun_path, "[socketpair]", 13);
auto& process = Process::current();
socket->m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
socket->set_acceptor(Process::current());
socket->set_connected(true);
socket->set_connect_side_role(Role::Connected);
socket->m_role = Role::Accepted;

View File

@ -38,8 +38,7 @@ Socket::Socket(int domain, int type, int protocol)
, m_type(type)
, m_protocol(protocol)
{
auto& process = Process::current();
m_origin = { process.pid().value(), process.uid().value(), process.gid().value() };
set_origin(Process::current());
}
Socket::~Socket()
@ -62,7 +61,7 @@ RefPtr<Socket> Socket::accept()
auto client = m_pending.take_first();
VERIFY(!client->is_connected());
auto& process = Process::current();
client->m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
client->set_acceptor(process);
client->m_connected = true;
client->m_role = Role::Accepted;
if (!m_pending.is_empty())
@ -274,4 +273,14 @@ void Socket::set_connected(bool connected)
evaluate_block_conditions();
}
void Socket::set_origin(Process const& process)
{
m_origin = { process.pid().value(), process.uid().value(), process.gid().value() };
}
void Socket::set_acceptor(Process const& process)
{
m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
}
}

View File

@ -137,6 +137,9 @@ protected:
return error;
}
void set_origin(Process const&);
void set_acceptor(Process const&);
protected:
ucred m_origin { 0, 0, 0 };
ucred m_acceptor { 0, 0, 0 };