LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Kernel: Explicitly initialize bools in IOAPIC mapping

Browse Source 
The compiler couldn't convince itself that these are always initialized
when compiling with Og. They are always initialized before use, because
the only branch where they weren't had VERIFY_NOT_REACHED.
This commit is contained in:
Andrew Kaster 2021-05-23 13:56:01 -06:00 committed by Andreas Kling
parent 86e3010043
commit 7fb05c5c23
Notes: sideshowbarker 2024-07-18 17:20:31 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/7fb05c5c234
Pull-request: https://github.com/SerenityOS/serenity/pull/7429
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/bgianfo ✅
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Kernel/Interrupts/IOAPIC.cpp
View File

@ -48,7 +48,7 @@ void IOAPIC::map_interrupt_redirection(u8 interrupt_vector)
for (auto redirection_override : InterruptManagement::the().isa_overrides()) {
if (redirection_override.source() != interrupt_vector)
continue;
bool active_low;
bool active_low = false;
// See ACPI spec Version 6.2, page 205 to learn more about Interrupt Overriding Flags.
switch ((redirection_override.flags() & 0b11)) {
case 0:
@ -64,7 +64,7 @@ void IOAPIC::map_interrupt_redirection(u8 interrupt_vector)
break;
}
bool trigger_level_mode;
bool trigger_level_mode = false;
// See ACPI spec Version 6.2, page 205 to learn more about Interrupt Overriding Flags.
switch (((redirection_override.flags() >> 2) & 0b11)) {
case 0:
@ -116,7 +116,7 @@ void IOAPIC::map_isa_interrupts()
for (auto redirection_override : InterruptManagement::the().isa_overrides()) {
if ((redirection_override.gsi() < gsi_base()) || (redirection_override.gsi() >= (gsi_base() + m_redirection_entries_count)))
continue;
bool active_low;
bool active_low = false;
// See ACPI spec Version 6.2, page 205 to learn more about Interrupt Overriding Flags.
switch ((redirection_override.flags() & 0b11)) {
case 0:
@ -132,7 +132,7 @@ void IOAPIC::map_isa_interrupts()
break;
}
bool trigger_level_mode;
bool trigger_level_mode = false;
// See ACPI spec Version 6.2, page 205 to learn more about Interrupt Overriding Flags.
switch (((redirection_override.flags() >> 2) & 0b11)) {
case 0: