LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

GHttp: Rename GHttpNetworkJob => GHttpJob. And tidy up a little bit.

Browse Source
This commit is contained in:
Andreas Kling 2019-04-08 02:24:34 +02:00
parent 37ae00a4dd
commit 7fcca0ce4b
Notes: sideshowbarker 2024-07-19 14:47:40 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/7fcca0ce4b7
4 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
LibGUI/GHttpNetworkJob.cpp → LibGUI/GHttpJob.cpp
View File

@ -1,19 +1,19 @@
#include <LibGUI/GHttpNetworkJob.h>
#include <LibGUI/GHttpJob.h>
#include <LibGUI/GHttpResponse.h>
#include <LibGUI/GTCPSocket.h>
#include <stdio.h>
#include <unistd.h>
GHttpNetworkJob::GHttpNetworkJob(const GHttpRequest& request)
GHttpJob::GHttpJob(const GHttpRequest& request)
: m_request(request)
{
}
GHttpNetworkJob::~GHttpNetworkJob()
GHttpJob::~GHttpJob()
{
}
void GHttpNetworkJob::start()
void GHttpJob::start()
{
ASSERT(!m_socket);
m_socket = new GTCPSocket(this);
@ -35,7 +35,7 @@ void GHttpNetworkJob::start()
while (!m_socket->can_read_line())
usleep(1);
ASSERT(m_socket->can_read_line());
auto line = m_socket->read_line(1024);
auto line = m_socket->read_line(PAGE_SIZE);
if (line.is_null()) {
printf("Expected HTTP status\n");
return deferred_invoke([this](auto&){ did_fail(GNetworkJob::Error::TransmissionFailed); });
@ -57,7 +57,7 @@ void GHttpNetworkJob::start()
if (m_state == State::InHeaders) {
while (!m_socket->can_read_line())
usleep(1);
auto line = m_socket->read_line(1024);
auto line = m_socket->read_line(PAGE_SIZE);
if (line.is_null()) {
printf("Expected HTTP header\n");
return did_fail(GNetworkJob::Error::ProtocolFailed);
@ -83,7 +83,7 @@ void GHttpNetworkJob::start()
continue;
}
ASSERT(m_state == State::InBody);
auto payload = m_socket->receive(100000);
auto payload = m_socket->receive(PAGE_SIZE);
if (!payload) {
if (m_socket->eof()) {
m_state = State::Finished;
@ -95,8 +95,7 @@ void GHttpNetworkJob::start()
}
auto response = GHttpResponse::create(m_code, move(m_headers), ByteBuffer::copy(buffer.data(), buffer.size()));
deferred_invoke([this, response] (GObject&) {
printf("in the deferred invoke lambda\n");
deferred_invoke([this, response] (auto&) {
did_finish(move(response));
});
}

8
LibGUI/GHttpNetworkJob.h → LibGUI/GHttpJob.h
View File

@ -6,14 +6,14 @@
class GTCPSocket;
class GHttpNetworkJob final : public GNetworkJob {
class GHttpJob final : public GNetworkJob {
public:
explicit GHttpNetworkJob(const GHttpRequest&);
virtual ~GHttpNetworkJob() override;
explicit GHttpJob(const GHttpRequest&);
virtual ~GHttpJob() override;
virtual void start() override;
virtual const char* class_name() const override { return "GHttpNetworkJob"; }
virtual const char* class_name() const override { return "GHttpJob"; }
private:
enum class State {

4
LibGUI/GHttpRequest.cpp
View File

@ -1,5 +1,5 @@
#include <LibGUI/GHttpRequest.h>
#include <LibGUI/GHttpNetworkJob.h>
#include <LibGUI/GHttpJob.h>
#include <LibGUI/GEventLoop.h>
#include <AK/StringBuilder.h>
@ -13,7 +13,7 @@ GHttpRequest::~GHttpRequest()
GNetworkJob* GHttpRequest::schedule()
{
auto* job = new GHttpNetworkJob(*this);
auto* job = new GHttpJob(*this);
job->start();
return job;
}

2
LibGUI/Makefile
View File

@ -62,7 +62,7 @@ LIBGUI_OBJS = \
GNetworkResponse.o \
GHttpRequest.o \
GHttpResponse.o \
GHttpNetworkJob.o \
GHttpJob.o \
GWindow.o
OBJS = $(SHAREDGRAPHICS_OBJS) $(LIBGUI_OBJS)