LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add auto as a recognized argument of flex-basis

Browse Source 
There isn't actually any special treatment of this over 'content' in
the FlexFormattingContext, for now both are treated the same.
This fixes #9225
This commit is contained in:
Tobias Christiansen 2021-08-06 22:00:25 +02:00 committed by Andreas Kling
parent 6852ba4d34
commit 833936f3ec
Notes: sideshowbarker 2024-07-18 07:19:00 +09:00 
Author: https://github.com/TobyAsE
Commit: https://github.com/SerenityOS/serenity/commit/833936f3ecc
Pull-request: https://github.com/SerenityOS/serenity/pull/9247
Issue: https://github.com/SerenityOS/serenity/issues/9225
4 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/ComputedValues.h
View File

@ -41,7 +41,7 @@ public:
};
struct FlexBasisData {
CSS::FlexBasis type { CSS::FlexBasis::Content };
CSS::FlexBasis type { CSS::FlexBasis::Auto };
CSS::Length length {};
};

3
Userland/Libraries/LibWeb/CSS/StyleProperties.cpp
View File

@ -285,6 +285,9 @@ Optional<CSS::FlexBasisData> StyleProperties::flex_basis() const
if (value.value()->is_identifier() && value.value()->to_identifier() == CSS::ValueID::Content)
return { { CSS::FlexBasis::Content, {} } };
if (value.value()->is_auto())
return { { CSS::FlexBasis::Auto, {} } };
if (value.value()->is_length())
return { { CSS::FlexBasis::Length, value.value()->to_length() } };

3
Userland/Libraries/LibWeb/CSS/StyleValue.h
View File

@ -96,7 +96,8 @@ enum class FlexWrap {
enum class FlexBasis {
Content,
Length
Length,
Auto,
};
enum class WhiteSpace {

1
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View File

@ -311,6 +311,7 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
} else {
// E
// FIXME: This is probably too naive.
// FIXME: Care about FlexBasis::Auto
if (has_definite_main_size(child_box)) {
flex_item.flex_base_size = specified_main_size(child_box);
} else {