LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-08 20:32:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibCore: Store the event loop stack as a function-scope thread_local

Browse Source 
By allocating the event loop stack onto the heap, we were leaking it
when exiting. This way, we should avoid ASAN being unhappy with us.
This commit is contained in:
Zaggy1024 2023-08-02 23:03:54 -05:00 committed by Andrew Kaster
parent 78e1defbfe
commit 8626404ddb
Notes: sideshowbarker 2024-07-17 10:39:39 +09:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/SerenityOS/serenity/commit/8626404ddb
Pull-request: https://github.com/SerenityOS/serenity/pull/19849
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/kleinesfilmroellchen
Reviewed-by: https://github.com/trflynn89
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibCore/EventLoop.cpp
View File

@ -17,11 +17,11 @@
namespace Core {
namespace {
thread_local Vector<EventLoop&>* s_event_loop_stack;
Vector<EventLoop&>& event_loop_stack()
{
if (!s_event_loop_stack)
s_event_loop_stack = new Vector<EventLoop&>;
thread_local OwnPtr<Vector<EventLoop&>> s_event_loop_stack = nullptr;
if (s_event_loop_stack == nullptr)
s_event_loop_stack = make<Vector<EventLoop&>>();
return *s_event_loop_stack;
}
}