LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibAudio: Tolerate a file sample rate lower than the AudioServer's

Browse Source 
Previously, trying to load a wav file in aplay or SoundPlayer with a
sample rate less than 44100 would crash in an assertion failure trying
to unchecked_append to a vector that was not resized properly.
This commit is contained in:
Andrew Kaster 2022-12-24 22:40:19 -07:00 committed by Andreas Kling
parent 140000f37a
commit 86995be111
Notes: sideshowbarker 2024-07-17 10:39:39 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/86995be111
Pull-request: https://github.com/SerenityOS/serenity/pull/16657
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibAudio/Resampler.h
View File

@ -62,7 +62,8 @@ public:
template<ArrayLike<SampleType> Samples, size_t vector_inline_capacity = 0> template<ArrayLike<SampleType> Samples, size_t vector_inline_capacity = 0>
ErrorOr<void> try_resample_into_end(Vector<SampleType, vector_inline_capacity>& destination, Samples&& to_resample) ErrorOr<void> try_resample_into_end(Vector<SampleType, vector_inline_capacity>& destination, Samples&& to_resample)
{ {
TRY(destination.try_ensure_capacity(destination.size() + to_resample.size() * ceil_div(m_source, m_target))); float ratio = (m_source > m_target) ? static_cast<float>(m_source) / m_target : static_cast<float>(m_target) / m_source;
TRY(destination.try_ensure_capacity(destination.size() + to_resample.size() * ratio));
for (auto sample : to_resample) { for (auto sample : to_resample) {
process_sample(sample, sample); process_sample(sample, sample);