LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LookupServer: Try other available DNS nameservers on network errors

Browse Source 
We were accidentally short-circuting DNS lookup on network errors when
contacting the first DNS server, instead of trying the other available
options.
This commit is contained in:
Idan Horowitz 2022-07-02 21:36:41 +03:00
parent c8d1c263d6
commit 888d8e53a3
Notes: sideshowbarker 2024-07-17 09:46:45 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/888d8e53a3
Pull-request: https://github.com/SerenityOS/serenity/pull/14458
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Services/LookupServer/LookupServer.cpp
View File

@ -196,7 +196,10 @@ ErrorOr<Vector<Answer>> LookupServer::lookup(Name const& name, RecordType record
int retries = 3;
Vector<Answer> upstream_answers;
do {
upstream_answers = TRY(lookup(name, nameserver, did_get_response, record_type));
auto upstream_answers_or_error = lookup(name, nameserver, did_get_response, record_type);
if (upstream_answers_or_error.is_error())
continue;
upstream_answers = upstream_answers_or_error.release_value();
if (did_get_response)
break;
} while (--retries);