LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 10:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use node_to_insert instead of node in Node::insert_before

Browse Source 
It was using the passed in node instead of the node from the vector.
Fixes a crash I found while testing jQuery.
This commit is contained in:
Luke 2021-05-03 02:06:11 +01:00 committed by Andreas Kling
parent 4cf5514672
commit 8b5ea01cfb
Notes: sideshowbarker 2024-07-18 18:45:54 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/8b5ea01cfb9
Pull-request: https://github.com/SerenityOS/serenity/pull/6831
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Node.cpp
View File

@ -232,9 +232,9 @@ void Node::insert_before(NonnullRefPtr<Node> node, RefPtr<Node> child, bool supp
document().adopt_node(node_to_insert);
if (!child)
TreeNode<Node>::append_child(node);
TreeNode<Node>::append_child(node_to_insert);
else
TreeNode<Node>::insert_before(node, child);
TreeNode<Node>::insert_before(node_to_insert, child);
// FIXME: If parent is a shadow host and node is a slottable, then assign a slot for node.
// FIXME: If parent’s root is a shadow root, and parent is a slot whose assigned nodes is the empty list, then run signal a slot change for parent.