LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-08 12:19:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

PixelPaint: Specify histogram height in GML

Browse Source 
The histogram is perfectly fine with being drawn at any size, but the
code currently fixes its height to 65. Once the histogram is in a
subclass and several GML things around it change, the fixed height
breaks, so we move the height specification to GML. Additionally, the
container is specified to shrink as much as possible, alleviating a
hard-coded UI size. The user can now change histogram height in GML,
which is a lot more obvious.
This commit is contained in:
kleines Filmröllchen 2022-08-28 16:26:23 +02:00 committed by Linus Groh
parent b2203e6417
commit 8b60305698
Notes: sideshowbarker 2024-07-17 07:32:32 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/8b60305698
Pull-request: https://github.com/SerenityOS/serenity/pull/14895
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/MacDue
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/trflynn89
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Applications/PixelPaint/HistogramWidget.cpp
View File

@ -16,11 +16,6 @@ REGISTER_WIDGET(PixelPaint, HistogramWidget);
namespace PixelPaint {
HistogramWidget::HistogramWidget()
{
set_height(65);
}
HistogramWidget::~HistogramWidget()
{
if (m_image)

2
Userland/Applications/PixelPaint/HistogramWidget.h
View File

@ -24,7 +24,7 @@ public:
void set_color_at_mouseposition(Color);
private:
HistogramWidget();
HistogramWidget() = default;
virtual void paint_event(GUI::PaintEvent&) override;

4
Userland/Applications/PixelPaint/PixelPaintWindow.gml
View File

@ -66,14 +66,14 @@
@GUI::GroupBox {
title: "Histogram"
max_height: 90
preferred_height: "shrink"
layout: @GUI::VerticalBoxLayout {
margins: [6]
}
@PixelPaint::HistogramWidget {
name: "histogram_widget"
max_height: 65
min_height: 65
}
}