LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Check if entryToReplace is contained in session history entries

Browse Source 
This small hack will allow us to get rid of "force processing of
session history traversal queue" which is significantly more cumbersome
hack.
This commit is contained in:
Aliaksandr Kalenik 2024-04-05 17:39:33 +02:00 committed by Alexander Kalenik
parent adcc3905e5
commit 8cc2ee34db
Notes: sideshowbarker 2024-07-17 01:46:00 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/8cc2ee34db
Pull-request: https://github.com/SerenityOS/serenity/pull/23853
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View File

@ -1011,7 +1011,9 @@ void finalize_a_same_document_navigation(JS::NonnullGCPtr<TraversableNavigable>
auto& target_entries = target_navigable->get_session_history_entries();
// 5. If entryToReplace is null, then:
if (!entry_to_replace) {
// FIXME: Checking containment of entryToReplace should not be needed.
// For more details see https://github.com/whatwg/html/issues/10232#issuecomment-2037543137
if (!entry_to_replace || !target_entries.contains_slow(JS::NonnullGCPtr { *entry_to_replace })) {
// 1. Clear the forward session history of traversable.
traversable->clear_the_forward_session_history();