LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Add a FIXME about race in AutocompleteBox::apply_suggestion()

Browse Source
This commit is contained in:
Itamar 2021-05-31 23:30:26 +03:00 committed by Andreas Kling
parent 7c2941d4ea
commit 8f6b496fed
Notes: sideshowbarker 2024-07-18 17:05:41 +09:00 
Author: https://github.com/itamar8910
Commit: https://github.com/SerenityOS/serenity/commit/8f6b496fedf
Pull-request: https://github.com/SerenityOS/serenity/pull/7453
Issue: https://github.com/SerenityOS/serenity/issues/7404
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/awesomekling
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibGUI/AutocompleteProvider.cpp
View File

@ -92,6 +92,10 @@ AutocompleteBox::AutocompleteBox(TextEditor& editor)
void AutocompleteBox::update_suggestions(Vector<AutocompleteProvider::Entry>&& suggestions)
{
// FIXME: There's a potential race here if, after the user selected an autocomplete suggestion,
// the LanguageServer sends an update and this function is executed before AutocompleteBox::apply_suggestion()
// is executed.
bool has_suggestions = !suggestions.is_empty();
if (m_suggestion_view->model()) {
auto& model = *static_cast<AutocompleteSuggestionModel*>(m_suggestion_view->model());