LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-16 08:50:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove painting command for drawing signed distance field

Browse Source 
No longer used since we switched to vector paths for checkbox rendering.
This commit is contained in:
Aliaksandr Kalenik 2024-06-13 17:39:24 +03:00 committed by Andreas Kling
parent 20c506f597
commit 9502926b76
Notes: sideshowbarker 2024-07-17 18:38:54 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9502926b76
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/152
11 changed files with 0 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Painting/AffineCommandExecutorCPU.cpp
View File

@ -227,12 +227,6 @@ CommandResult AffineCommandExecutorCPU::draw_line(DrawLine const& command)
return CommandResult::Continue;
}
CommandResult AffineCommandExecutorCPU::draw_signed_distance_field(DrawSignedDistanceField const&)
{
// FIXME: Implement.
return CommandResult::Continue;
}
CommandResult AffineCommandExecutorCPU::apply_backdrop_filter(ApplyBackdropFilter const&)
{
// FIXME: Implement.

1
Userland/Libraries/LibWeb/Painting/AffineCommandExecutorCPU.h
View File

@ -35,7 +35,6 @@ public:
CommandResult draw_ellipse(DrawEllipse const&) override;
CommandResult fill_ellipse(FillEllipse const&) override;
CommandResult draw_line(DrawLine const&) override;
CommandResult draw_signed_distance_field(DrawSignedDistanceField const&) override;
CommandResult apply_backdrop_filter(ApplyBackdropFilter const&) override;
CommandResult draw_rect(DrawRect const&) override;
CommandResult paint_radial_gradient(PaintRadialGradient const&) override;

15
Userland/Libraries/LibWeb/Painting/Command.h
View File

@ -286,20 +286,6 @@ struct DrawLine {
}
};
struct DrawSignedDistanceField {
Gfx::IntRect rect;
Color color;
Gfx::GrayscaleBitmap sdf;
float smoothing;
[[nodiscard]] Gfx::IntRect bounding_rect() const { return rect; }
void translate_by(Gfx::IntPoint const& offset)
{
rect.translate_by(offset);
}
};
struct ApplyBackdropFilter {
Gfx::IntRect backdrop_region;
BorderRadiiData border_radii_data;
@ -404,7 +390,6 @@ using Command = Variant<
DrawEllipse,
FillEllipse,
DrawLine,
DrawSignedDistanceField,
ApplyBackdropFilter,
DrawRect,
DrawTriangleWave,

6
Userland/Libraries/LibWeb/Painting/CommandExecutorCPU.cpp
View File

@ -381,12 +381,6 @@ CommandResult CommandExecutorCPU::draw_line(DrawLine const& command)
return CommandResult::Continue;
}
CommandResult CommandExecutorCPU::draw_signed_distance_field(DrawSignedDistanceField const& command)
{
painter().draw_signed_distance_field(command.rect, command.color, command.sdf, command.smoothing);
return CommandResult::Continue;
}
CommandResult CommandExecutorCPU::apply_backdrop_filter(ApplyBackdropFilter const& command)
{
auto& painter = this->painter();

1
Userland/Libraries/LibWeb/Painting/CommandExecutorCPU.h
View File

@ -36,7 +36,6 @@ public:
CommandResult draw_ellipse(DrawEllipse const&) override;
CommandResult fill_ellipse(FillEllipse const&) override;
CommandResult draw_line(DrawLine const&) override;
CommandResult draw_signed_distance_field(DrawSignedDistanceField const&) override;
CommandResult apply_backdrop_filter(ApplyBackdropFilter const&) override;
CommandResult draw_rect(DrawRect const&) override;
CommandResult paint_radial_gradient(PaintRadialGradient const&) override;

6
Userland/Libraries/LibWeb/Painting/CommandExecutorGPU.cpp
View File

@ -268,12 +268,6 @@ CommandResult CommandExecutorGPU::draw_line(DrawLine const& command)
return CommandResult::Continue;
}
CommandResult CommandExecutorGPU::draw_signed_distance_field(DrawSignedDistanceField const&)
{
// FIXME
return CommandResult::Continue;
}
CommandResult CommandExecutorGPU::apply_backdrop_filter(ApplyBackdropFilter const&)
{
// FIXME

1
Userland/Libraries/LibWeb/Painting/CommandExecutorGPU.h
View File

@ -35,7 +35,6 @@ public:
CommandResult draw_ellipse(DrawEllipse const&) override;
CommandResult fill_ellipse(FillEllipse const&) override;
CommandResult draw_line(DrawLine const&) override;
CommandResult draw_signed_distance_field(DrawSignedDistanceField const&) override;
CommandResult apply_backdrop_filter(ApplyBackdropFilter const&) override;
CommandResult draw_rect(DrawRect const&) override;
CommandResult paint_radial_gradient(PaintRadialGradient const&) override;

1
Userland/Libraries/LibWeb/Painting/CommandList.cpp
View File

@ -172,7 +172,6 @@ void CommandList::execute(CommandExecutor& executor)
else HANDLE_COMMAND(DrawEllipse, draw_ellipse)
else HANDLE_COMMAND(FillEllipse, fill_ellipse)
else HANDLE_COMMAND(DrawLine, draw_line)
else HANDLE_COMMAND(DrawSignedDistanceField, draw_signed_distance_field)
else HANDLE_COMMAND(ApplyBackdropFilter, apply_backdrop_filter)
else HANDLE_COMMAND(DrawRect, draw_rect)
else HANDLE_COMMAND(DrawTriangleWave, draw_triangle_wave)

1
Userland/Libraries/LibWeb/Painting/CommandList.h
View File

@ -70,7 +70,6 @@ public:
virtual CommandResult draw_ellipse(DrawEllipse const&) = 0;
virtual CommandResult fill_ellipse(FillEllipse const&) = 0;
virtual CommandResult draw_line(DrawLine const&) = 0;
virtual CommandResult draw_signed_distance_field(DrawSignedDistanceField const&) = 0;
virtual CommandResult apply_backdrop_filter(ApplyBackdropFilter const&) = 0;
virtual CommandResult draw_rect(DrawRect const&) = 0;
virtual CommandResult draw_triangle_wave(DrawTriangleWave const&) = 0;

12
Userland/Libraries/LibWeb/Painting/RecordingPainter.cpp
View File

@ -237,18 +237,6 @@ void RecordingPainter::draw_text(Gfx::IntRect const& rect, String raw_text, Gfx:
});
}
void RecordingPainter::draw_signed_distance_field(Gfx::IntRect const& dst_rect, Color color, Gfx::GrayscaleBitmap const& sdf, float smoothing)
{
if (dst_rect.is_empty())
return;
append(DrawSignedDistanceField {
.rect = state().translation.map(dst_rect),
.color = color,
.sdf = sdf,
.smoothing = smoothing,
});
}
void RecordingPainter::draw_text_run(Gfx::IntPoint baseline_start, Gfx::GlyphRun const& glyph_run, Color color, Gfx::IntRect const& rect, double scale)
{
if (rect.is_empty())

2
Userland/Libraries/LibWeb/Painting/RecordingPainter.h
View File

@ -97,8 +97,6 @@ public:
void draw_text(Gfx::IntRect const&, String, Gfx::Font const&, Gfx::TextAlignment = Gfx::TextAlignment::TopLeft, Color = Color::Black, Gfx::TextElision = Gfx::TextElision::None, Gfx::TextWrapping = Gfx::TextWrapping::DontWrap);
void draw_signed_distance_field(Gfx::IntRect const& dst_rect, Color color, Gfx::GrayscaleBitmap const& sdf, float smoothing);
// Streamlined text drawing routine that does no wrapping/elision/alignment.
void draw_text_run(Gfx::IntPoint baseline_start, Gfx::GlyphRun const& glyph_run, Color color, Gfx::IntRect const& rect, double scale);