LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-04 05:19:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

AK: Don't unlink intrusive list elements in the destructor

Browse Source 
Removing the element from the intrusive linked list might not be safe
if doing so requires a lock. Instead this is something the caller
should have done so let's verify instead that we're not on any lists.
This commit is contained in:
Gunnar Beutner 2021-05-19 23:42:28 +02:00 committed by Andreas Kling
parent c46ab4fbb9
commit 96b75af5d1
Notes: sideshowbarker 2024-07-18 17:43:33 +09:00 
Author: https://github.com/gunnarbeutner
Commit: https://github.com/SerenityOS/serenity/commit/96b75af5d13
Pull-request: https://github.com/SerenityOS/serenity/pull/7301
Reviewed-by: https://github.com/bgianfo ✅
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
AK/IntrusiveList.h
View File

@ -320,8 +320,7 @@ namespace Detail {
template<typename T, typename Container> template<typename T, typename Container>
inline IntrusiveListNode<T, Container>::~IntrusiveListNode() inline IntrusiveListNode<T, Container>::~IntrusiveListNode()
{ {
if (m_storage) VERIFY(!is_in_list());
remove();
} }
template<typename T, typename Container> template<typename T, typename Container>