LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-29 14:14:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Always run layout and style updates from event loop processing

Browse Source 
Before this change, we ran style and layout updates from both event
loop processing and update timers. This could have caused missed resize
observer updates and unnecessary updating of style or layout more than
once before repaint.

Also, we can now be sure unnecessary style or layout updates won't
happen in `EventLoop::spin_processing_tasks_with_source_until()`.
This commit is contained in:
Aliaksandr Kalenik 2024-03-20 18:19:58 +01:00 committed by Andreas Kling
parent e09816c37c
commit 96d67ded3e
Notes: sideshowbarker 2024-07-16 23:44:30 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/96d67ded3e
Pull-request: https://github.com/SerenityOS/serenity/pull/23652
Reviewed-by: https://github.com/ADKaster ✅
2 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Userland/Libraries/LibWeb/DOM/Document.cpp
View File

@ -356,14 +356,6 @@ Document::Document(JS::Realm& realm, const URL::URL& url)
};
HTML::main_thread_event_loop().register_document({}, *this);
m_style_update_timer = Core::Timer::create_single_shot(0, [this] {
update_style();
}).release_value_but_fixme_should_propagate_errors();
m_layout_update_timer = Core::Timer::create_single_shot(0, [this] {
update_layout();
}).release_value_but_fixme_should_propagate_errors();
}
Document::~Document()
@ -681,16 +673,14 @@ void Document::set_origin(HTML::Origin const& origin)
void Document::schedule_style_update()
{
if (m_style_update_timer->is_active())
return;
m_style_update_timer->start();
// NOTE: Update of the style is a step in HTML event loop processing.
HTML::main_thread_event_loop().schedule();
}
void Document::schedule_layout_update()
{
if (m_layout_update_timer->is_active())
return;
m_layout_update_timer->start();
// NOTE: Update of the layout is a step in HTML event loop processing.
HTML::main_thread_event_loop().schedule();
}
bool Document::is_child_allowed(Node const& node) const
@ -1113,7 +1103,6 @@ void Document::update_layout()
paintable()->recompute_selection_states();
m_needs_layout = false;
m_layout_update_timer->stop();
}
[[nodiscard]] static CSS::RequiredInvalidationAfterStyleChange update_style_recursively(Node& node)
@ -1196,7 +1185,6 @@ void Document::update_style()
invalidate_stacking_context_tree();
}
m_needs_full_style_update = false;
m_style_update_timer->stop();
}
void Document::update_paint_and_hit_testing_properties_if_needed()

3
Userland/Libraries/LibWeb/DOM/Document.h
View File

@ -656,9 +656,6 @@ private:
Optional<Color> m_active_link_color;
Optional<Color> m_visited_link_color;
RefPtr<Core::Timer> m_style_update_timer;
RefPtr<Core::Timer> m_layout_update_timer;
JS::GCPtr<HTML::HTMLParser> m_parser;
bool m_active_parser_was_aborted { false };