mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 05:25:32 +03:00
Meta: Use proper versions in is_compiler_supported check in serenity.sh
We were checking the compilers against clang-12 and gcc-10. Since the check itself is confusing, some comments are warranted.
This commit is contained in:
parent
d9c1eb860f
commit
9bf2a7c7e5
Notes:
sideshowbarker
2024-07-17 04:04:33 +09:00
Author: https://github.com/ADKaster Commit: https://github.com/SerenityOS/serenity/commit/9bf2a7c7e5 Pull-request: https://github.com/SerenityOS/serenity/pull/16042 Reviewed-by: https://github.com/BertalanD Reviewed-by: https://github.com/linusg
@ -156,9 +156,11 @@ is_supported_compiler() {
|
||||
if $COMPILER --version 2>&1 | grep "Apple clang" >/dev/null; then
|
||||
return 1
|
||||
elif $COMPILER --version 2>&1 | grep "clang" >/dev/null; then
|
||||
[ "$MAJOR_VERSION" -gt 12 ] && return 0
|
||||
# Clang version check
|
||||
[ "$MAJOR_VERSION" -ge 13 ] && return 0
|
||||
else
|
||||
[ "$MAJOR_VERSION" -gt 10 ] && return 0
|
||||
# GCC version check
|
||||
[ "$MAJOR_VERSION" -ge 12 ] && return 0
|
||||
fi
|
||||
return 1
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user