LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-06 02:55:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

less: Fix out of bounds StringView indexing

Browse Source 
This fixes indexing the StringView before knowing if the index
is valid. This did not crash until the changes from 13406b8
which added runtime checks for StringView indexing.
This commit is contained in:
MacDue 2022-07-27 12:50:29 +01:00 committed by Tim Flynn
parent d1671d4f86
commit 9d0dccaa3f
Notes: sideshowbarker 2024-07-17 08:32:24 +09:00 
Author: https://github.com/MacDue
Commit: https://github.com/SerenityOS/serenity/commit/9d0dccaa3f
Pull-request: https://github.com/SerenityOS/serenity/pull/14704
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Utilities/less.cpp
View File

@ -332,7 +332,7 @@ private:
size_t render_status_line(StringView prompt, size_t off = 0, char end = '\0', bool ignored = false)
{
for (; prompt[off] != end && off < prompt.length(); ++off) {
for (; off < prompt.length() && prompt[off] != end; ++off) {
if (ignored)
continue;