LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 09:17:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Kernel+SystemServer: Make KCOVDevice a character device

Browse Source 
This device should not be a block device, as in Serenity, block devices
represent an interface to either disk partitions or storage devices.
This commit is contained in:
Liav A 2022-07-09 10:10:21 +03:00 committed by Andreas Kling
parent b1ed151c9c
commit 9dbec601b0
Notes: sideshowbarker 2024-07-17 09:32:21 +09:00 
Author: https://github.com/supercomputer7
Commit: https://github.com/SerenityOS/serenity/commit/9dbec601b0
Pull-request: https://github.com/SerenityOS/serenity/pull/14521
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Kernel/Devices/KCOVDevice.cpp
View File

@ -28,7 +28,7 @@ UNMAP_AFTER_INIT NonnullRefPtr<KCOVDevice> KCOVDevice::must_create()
}
UNMAP_AFTER_INIT KCOVDevice::KCOVDevice()
: BlockDevice(30, 0)
: CharacterDevice(30, 0)
{
proc_instance = new HashMap<ProcessID, KCOVInstance*>();
thread_instance = new HashMap<ThreadID, KCOVInstance*>();

5
Kernel/Devices/KCOVDevice.h
View File

@ -6,11 +6,11 @@
#pragma once
#include <Kernel/Devices/BlockDevice.h>
#include <Kernel/Devices/CharacterDevice.h>
#include <Kernel/Devices/KCOVInstance.h>
namespace Kernel {
class KCOVDevice final : public BlockDevice {
class KCOVDevice final : public CharacterDevice {
friend class DeviceManagement;
public:
@ -32,7 +32,6 @@ protected:
virtual bool can_read(OpenFileDescription const&, u64) const override final { return true; }
virtual bool can_write(OpenFileDescription const&, u64) const override final { return true; }
virtual void start_request(AsyncBlockDeviceRequest& request) override final { request.complete(AsyncDeviceRequest::Failure); }
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override { return EINVAL; }
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t) override { return EINVAL; }
virtual ErrorOr<void> ioctl(OpenFileDescription&, unsigned request, Userspace<void*> arg) override;

4
Userland/Services/SystemServer/main.cpp
View File

@ -275,8 +275,8 @@ static void populate_devtmpfs_devices_based_on_devctl()
break;
}
case 30: {
if (is_block_device) {
create_devtmpfs_block_device(String::formatted("/dev/kcov{}", minor_number), 0666, 30, minor_number);
if (!is_block_device) {
create_devtmpfs_char_device(String::formatted("/dev/kcov{}", minor_number), 0666, 30, minor_number);
}
break;
}