LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-16 08:50:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibLocale: Remove unused parameter from keyword canonicalization

Browse Source
This commit is contained in:
Timothy Flynn 2024-06-15 20:11:20 -04:00 committed by Andreas Kling
parent 5e2ee4447e
commit a1464342e1
Notes: sideshowbarker 2024-07-18 03:23:00 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a1464342e1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/176
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.cpp
View File

@ -470,7 +470,7 @@ LocaleResult resolve_locale(Vector<String> const& requested_locales, LocaleOptio
if (options_value.has_value()) {
// 1. Let optionsValue be the string optionsValue after performing the algorithm steps to transform Unicode extension values to canonical syntax per Unicode Technical Standard #35 LDML § 3.2.1 Canonical Unicode Locale Identifiers, treating key as ukey and optionsValue as uvalue productions.
// 2. Let optionsValue be the string optionsValue after performing the algorithm steps to replace Unicode extension values with their canonical form per Unicode Technical Standard #35 LDML § 3.2.1 Canonical Unicode Locale Identifiers, treating key as ukey and optionsValue as uvalue productions.
::Locale::canonicalize_unicode_extension_values(key, *options_value, true);
::Locale::canonicalize_unicode_extension_values(key, *options_value);
// 3. If optionsValue is the empty String, then
if (options_value->is_empty()) {

2
Userland/Libraries/LibLocale/Locale.cpp
View File

@ -494,7 +494,7 @@ String canonicalize_unicode_locale_id(StringView locale)
return locale_data->to_string();
}
void canonicalize_unicode_extension_values(StringView key, String& value, bool)
void canonicalize_unicode_extension_values(StringView key, String& value)
{
UErrorCode status = U_ZERO_ERROR;

2
Userland/Libraries/LibLocale/Locale.h
View File

@ -128,7 +128,7 @@ Optional<LanguageID> parse_unicode_language_id(StringView);
Optional<LocaleID> parse_unicode_locale_id(StringView);
String canonicalize_unicode_locale_id(StringView);
void canonicalize_unicode_extension_values(StringView key, String& value, bool remove_true);
void canonicalize_unicode_extension_values(StringView key, String& value);
StringView default_locale();
bool is_locale_available(StringView locale);