LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-08 12:19:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

PDFViewer: Prevent infinity recursion

Browse Source 
When removing all contents from the NumericInput box in PDFViewer the
callback set the (empty) text again back in the box, triggering another
callback in a recursive, non-stopping fashion. Not setting the text back
in the box avoids the problem.
This commit is contained in:
Rodrigo Tobar 2022-11-22 23:08:56 +08:00 committed by Andreas Kling
parent bc7da24fe6
commit a740423e23
Notes: sideshowbarker 2024-07-18 08:59:31 +09:00 
Author: https://github.com/rtobar
Commit: https://github.com/SerenityOS/serenity/commit/a740423e23
Pull-request: https://github.com/SerenityOS/serenity/pull/16155
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Applications/PDFViewer/NumericInput.cpp
View File

@ -29,7 +29,6 @@ NumericInput::NumericInput()
auto new_number_opt = builder.to_string().to_int();
if (!new_number_opt.has_value()) {
m_needs_text_reset = true;
set_text(builder.to_string());
return;
} else {
m_needs_text_reset = false;