LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

mv: Use ArgsParser, and check lstat for failure

Browse Source
This commit is contained in:
howar6hill 2020-02-21 19:56:05 +08:00 committed by Andreas Kling
parent 1d2986ea15
commit a78ae917d8
Notes: sideshowbarker 2024-07-19 17:39:22 +09:00 
Author: https://github.com/f-eiwu
Commit: https://github.com/SerenityOS/serenity/commit/a78ae917d88
Pull-request: https://github.com/SerenityOS/serenity/pull/1266
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Userland/mv.cpp
View File

@ -26,6 +26,7 @@
#include <AK/FileSystemPath.h>
#include <AK/String.h>
#include <LibCore/ArgsParser.h>
#include <stdio.h>
#include <sys/stat.h>
#include <unistd.h>
@ -37,24 +38,30 @@ int main(int argc, char** argv)
return 1;
}
if (argc != 3) {
printf("usage: mv <old-path> <new-path>\n");
const char* old_path = nullptr;
const char* new_path = nullptr;
Core::ArgsParser args_parser;
args_parser.add_positional_argument(old_path, "The file or directory being moved", "source");
args_parser.add_positional_argument(new_path, "destination of the move operation", "destination");
args_parser.parse(argc, argv);
struct stat st;
int rc = lstat(new_path, &st);
if (rc != 0 && errno != ENOENT) {
perror("lstat");
return 1;
}
String old_path = argv[1];
String new_path = argv[2];
struct stat st;
int rc = lstat(new_path.characters(), &st);
if (rc == 0) {
if (S_ISDIR(st.st_mode)) {
auto old_basename = FileSystemPath(old_path).basename();
new_path = String::format("%s/%s", new_path.characters(), old_basename.characters());
}
String combined_new_path;
if (rc == 0 && S_ISDIR(st.st_mode)) {
auto old_basename = FileSystemPath(old_path).basename();
combined_new_path = String::format("%s/%s", new_path, old_basename.characters());
new_path = combined_new_path.characters();
}
rc = rename(old_path.characters(), new_path.characters());
rc = rename(old_path, new_path);
if (rc < 0) {
perror("rename");
return 1;