LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-26 04:35:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibC: Align _ctype_ to newlib's implementation

Browse Source 
newlib has an extra character slot at the beginning to enable some
macro tricks that cause a warning when someone passes a type that's not
"int" into a ctype function. Our deviation from this causes issues for
LLVM.
This commit is contained in:
Andrew Kaster 2022-06-26 19:11:09 -06:00 committed by Linus Groh
parent 6223841d69
commit a80493d221
Notes: sideshowbarker 2024-07-17 11:30:05 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/a80493d221
Pull-request: https://github.com/SerenityOS/serenity/pull/14401
Reviewed-by: https://github.com/BertalanD ✅
Reviewed-by: https://github.com/timschumi
2 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibC/ctype.cpp
View File

@ -8,7 +8,8 @@
extern "C" {
char const _ctype_[256] = {
char const _ctype_[1 + 256] = {
0,
_C, _C, _C, _C, _C, _C, _C, _C,
_C, _C | _S, _C | _S, _C | _S, _C | _S, _C | _S, _C, _C,
_C, _C, _C, _C, _C, _C, _C, _C,

35
Userland/Libraries/LibC/ctype.h
View File

@ -10,6 +10,10 @@
__BEGIN_DECLS
#ifndef EOF
# define EOF (-1)
#endif
/* Do what newlib does to appease GCC's --with-newlib option. */
#define _U 01
#define _L 02
@ -20,16 +24,21 @@ __BEGIN_DECLS
#define _X 0100
#define _B 0200
extern char const _ctype_[256] __attribute__((visibility("default")));
/**
* newlib has a 257 byte _ctype_ array to enable compiler tricks to catch
* people passing char instead of int. We don't engage in those tricks,
* but still claim to be newlib to the toolchains
*/
extern char const _ctype_[1 + 256] __attribute__((visibility("default")));
static inline int __inline_isalnum(int c)
{
return _ctype_[(unsigned char)(c)] & (_U | _L | _N);
return _ctype_[(unsigned char)(c) + 1] & (_U | _L | _N);
}
static inline int __inline_isalpha(int c)
{
return _ctype_[(unsigned char)(c)] & (_U | _L);
return _ctype_[(unsigned char)(c) + 1] & (_U | _L);
}
static inline int __inline_isascii(int c)
@ -39,52 +48,52 @@ static inline int __inline_isascii(int c)
static inline int __inline_iscntrl(int c)
{
return _ctype_[(unsigned char)(c)] & (_C);
return _ctype_[(unsigned char)(c) + 1] & (_C);
}
static inline int __inline_isdigit(int c)
{
return _ctype_[(unsigned char)(c)] & (_N);
return _ctype_[(unsigned char)(c) + 1] & (_N);
}
static inline int __inline_isxdigit(int c)
{
return _ctype_[(unsigned char)(c)] & (_N | _X);
return _ctype_[(unsigned char)(c) + 1] & (_N | _X);
}
static inline int __inline_isspace(int c)
{
return _ctype_[(unsigned char)(c)] & (_S);
return _ctype_[(unsigned char)(c) + 1] & (_S);
}
static inline int __inline_ispunct(int c)
{
return _ctype_[(unsigned char)(c)] & (_P);
return _ctype_[(unsigned char)(c) + 1] & (_P);
}
static inline int __inline_isprint(int c)
{
return _ctype_[(unsigned char)(c)] & (_P | _U | _L | _N | _B);
return _ctype_[(unsigned char)(c) + 1] & (_P | _U | _L | _N | _B);
}
static inline int __inline_isgraph(int c)
{
return _ctype_[(unsigned char)(c)] & (_P | _U | _L | _N);
return _ctype_[(unsigned char)(c) + 1] & (_P | _U | _L | _N);
}
static inline int __inline_islower(int c)
{
return _ctype_[(unsigned char)(c)] & (_L);
return _ctype_[(unsigned char)(c) + 1] & (_L);
}
static inline int __inline_isupper(int c)
{
return _ctype_[(unsigned char)(c)] & (_U);
return _ctype_[(unsigned char)(c) + 1] & (_U);
}
static inline int __inline_isblank(int c)
{
return _ctype_[(unsigned char)(c)] & (_B) || (c == '\t');
return _ctype_[(unsigned char)(c) + 1] & (_B) || (c == '\t');
}
static inline int __inline_toascii(int c)