LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-10-26 14:57:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Add a default virtual destructor to virtual classes

Browse Source 
Affected classes are children of TextDocumentUndoCommand:
 - InsertTextCommand
 - RemoveTextCommand
 - ReplaceAllTextCommand
This commit is contained in:
Lucas CHOLLET 2022-06-07 16:07:02 +02:00 committed by Linus Groh
parent cb4844bf64
commit a85223e13b
Notes: sideshowbarker 2024-07-17 11:30:05 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/a85223e13b
Pull-request: https://github.com/SerenityOS/serenity/pull/14221
Issue: https://github.com/SerenityOS/serenity/issues/8071
Reviewed-by: https://github.com/linusg
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibGUI/TextDocument.h
View File

@ -215,6 +215,7 @@ protected:
class InsertTextCommand : public TextDocumentUndoCommand {
public:
InsertTextCommand(TextDocument&, String const&, TextPosition const&);
virtual ~InsertTextCommand() = default;
virtual void perform_formatting(TextDocument::Client const&) override;
virtual void undo() override;
virtual void redo() override;
@ -231,6 +232,7 @@ private:
class RemoveTextCommand : public TextDocumentUndoCommand {
public:
RemoveTextCommand(TextDocument&, String const&, TextRange const&);
virtual ~RemoveTextCommand() = default;
virtual void undo() override;
virtual void redo() override;
TextRange const& range() const { return m_range; }
@ -246,6 +248,7 @@ class ReplaceAllTextCommand final : public GUI::TextDocumentUndoCommand {
public:
ReplaceAllTextCommand(GUI::TextDocument& document, String const& text, GUI::TextRange const& range, String const& action_text);
virtual ~ReplaceAllTextCommand() = default;
void redo() override;
void undo() override;
bool merge_with(GUI::Command const&) override;