LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove unnecessary check that BFC isn't clearing a flex item

Browse Source 
A block-level box in BFC will never be a flex item. It may be a flex
container, but not an item. Hence this check was unnecessary.
This commit is contained in:
Andreas Kling 2024-03-26 12:59:08 +01:00
parent a0ed8bdb57
commit aa59419529
Notes: sideshowbarker 2024-07-17 02:37:08 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/aa59419529
Pull-request: https://github.com/SerenityOS/serenity/pull/23742
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View File

@ -826,10 +826,9 @@ BlockFormattingContext::DidIntroduceClearance BlockFormattingContext::clear_floa
}
};
// Flex-items don't float and also don't clear.
if ((computed_values.clear() == CSS::Clear::Left || computed_values.clear() == CSS::Clear::Both) && !child_box.is_flex_item())
if (computed_values.clear() == CSS::Clear::Left || computed_values.clear() == CSS::Clear::Both)
clear_floating_boxes(m_left_floats);
if ((computed_values.clear() == CSS::Clear::Right || computed_values.clear() == CSS::Clear::Both) && !child_box.is_flex_item())
if (computed_values.clear() == CSS::Clear::Right || computed_values.clear() == CSS::Clear::Both)
clear_floating_boxes(m_right_floats);
return result;