mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 13:36:13 +03:00
Plug leaks in SynthFS::remove_file().
The process spawn stress test can now run forever. :^)
This commit is contained in:
parent
3f3535213b
commit
ab72666f48
Notes:
sideshowbarker
2024-07-19 16:06:55 +09:00
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/ab72666f481
@ -1,6 +1,21 @@
|
|||||||
#include "StringImpl.h"
|
#include "StringImpl.h"
|
||||||
#include "StdLibExtras.h"
|
#include "StdLibExtras.h"
|
||||||
#include "kmalloc.h"
|
#include "kmalloc.h"
|
||||||
|
#include "HashTable.h"
|
||||||
|
|
||||||
|
#ifdef DEBUG_STRINGIMPL
|
||||||
|
unsigned g_stringimpl_count;
|
||||||
|
static HashTable<StringImpl*>* g_all_live_stringimpls;
|
||||||
|
|
||||||
|
void dump_all_stringimpls()
|
||||||
|
{
|
||||||
|
unsigned i = 0;
|
||||||
|
for (auto& it : *g_all_live_stringimpls) {
|
||||||
|
dbgprintf("%u: \"%s\"\n", i, (*it).characters());
|
||||||
|
++i;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
#endif
|
||||||
|
|
||||||
namespace AK {
|
namespace AK {
|
||||||
|
|
||||||
@ -9,6 +24,10 @@ static StringImpl* s_the_empty_stringimpl = nullptr;
|
|||||||
void StringImpl::initialize_globals()
|
void StringImpl::initialize_globals()
|
||||||
{
|
{
|
||||||
s_the_empty_stringimpl = nullptr;
|
s_the_empty_stringimpl = nullptr;
|
||||||
|
#ifdef DEBUG_STRINGIMPL
|
||||||
|
g_stringimpl_count = 0;
|
||||||
|
g_all_live_stringimpls = new HashTable<StringImpl*>;
|
||||||
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
StringImpl& StringImpl::the_empty_stringimpl()
|
StringImpl& StringImpl::the_empty_stringimpl()
|
||||||
@ -18,8 +37,22 @@ StringImpl& StringImpl::the_empty_stringimpl()
|
|||||||
return *s_the_empty_stringimpl;
|
return *s_the_empty_stringimpl;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
StringImpl::StringImpl(ConstructWithInlineBufferTag, size_t length)
|
||||||
|
: m_length(length)
|
||||||
|
, m_characters(m_inline_buffer)
|
||||||
|
{
|
||||||
|
#ifdef DEBUG_STRINGIMPL
|
||||||
|
++g_stringimpl_count;
|
||||||
|
g_all_live_stringimpls->set(this);
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
||||||
StringImpl::~StringImpl()
|
StringImpl::~StringImpl()
|
||||||
{
|
{
|
||||||
|
#ifdef DEBUG_STRINGIMPL
|
||||||
|
--g_stringimpl_count;
|
||||||
|
g_all_live_stringimpls->remove(this);
|
||||||
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline size_t allocationSizeForStringImpl(size_t length)
|
static inline size_t allocationSizeForStringImpl(size_t length)
|
||||||
|
@ -37,7 +37,7 @@ private:
|
|||||||
explicit StringImpl(ConstructTheEmptyStringImplTag) : m_characters("") { }
|
explicit StringImpl(ConstructTheEmptyStringImplTag) : m_characters("") { }
|
||||||
|
|
||||||
enum ConstructWithInlineBufferTag { ConstructWithInlineBuffer };
|
enum ConstructWithInlineBufferTag { ConstructWithInlineBuffer };
|
||||||
explicit StringImpl(ConstructWithInlineBufferTag, size_t length) : m_length(length), m_characters(m_inline_buffer) { }
|
StringImpl(ConstructWithInlineBufferTag, size_t length);
|
||||||
|
|
||||||
void compute_hash() const;
|
void compute_hash() const;
|
||||||
|
|
||||||
|
@ -116,8 +116,12 @@ bool SynthFS::remove_file(InodeIndex inode)
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Vector<InodeIndex> indices_to_remove;
|
||||||
|
indices_to_remove.ensureCapacity(file.m_children.size());
|
||||||
for (auto& child : file.m_children)
|
for (auto& child : file.m_children)
|
||||||
remove_file(child->m_metadata.inode.index());
|
indices_to_remove.unchecked_append(child->m_metadata.inode.index());
|
||||||
|
for (auto& index : indices_to_remove)
|
||||||
|
remove_file(index);
|
||||||
m_inodes.remove(inode);
|
m_inodes.remove(inode);
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user