From ac1d87b9905ba9e321642c9915e78c2a7bbee557 Mon Sep 17 00:00:00 2001
From: Andrew Kaster <andrewdkaster@gmail.com>
Date: Sat, 15 May 2021 15:50:24 -0600
Subject: [PATCH] CI: Compile and run Lagom tests with ASAN and UBSAN

Make sure halt_on_error=1 is enabled so that UBSAN failures will crash
the test program and cause a failure.
---
 .github/workflows/cmake.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
index 9335dd6bb91..dfef0bdbb0c 100644
--- a/.github/workflows/cmake.yml
+++ b/.github/workflows/cmake.yml
@@ -216,7 +216,7 @@ jobs:
       run: |
         mkdir -p Build
         cd Build
-        cmake -GNinja -DBUILD_LAGOM=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10 ..
+        cmake -GNinja -DBUILD_LAGOM=ON -DENABLE_UNDEFINED_SANITIZER=ON -DENABLE_ADDRESS_SANITIZER=ON -DENABLE_PCI_IDS_DOWNLOAD=OFF -DCMAKE_C_COMPILER=gcc-10 -DCMAKE_CXX_COMPILER=g++-10 ..
       if: ${{ matrix.with-fuzzers == 'NO_FUZZ' }}
 
     # === ACTUALLY BUILD AND TEST ===
@@ -227,8 +227,11 @@ jobs:
 
     - name: Run CMake tests
       working-directory: ${{ github.workspace }}/Meta/Lagom/Build
-      run: CTEST_OUTPUT_ON_FAILURE=1 ninja test || ${{ matrix.allow-test-failure }}
+      run: ninja test || ${{ matrix.allow-test-failure }}
       timeout-minutes: 4
+      env:
+        CTEST_OUTPUT_ON_FAILURE: 1
+        UBSAN_OPTIONS: "halt_on_error=1"
       if: ${{ matrix.with-fuzzers == 'NO_FUZZ' }}
 
   lint_commits: