LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement [SameObject] behavior for HTMLTableSectionElement.rows

Browse Source
This commit is contained in:
Andreas Kling 2022-11-24 19:04:27 +01:00
parent d7c58aa58d
commit ad36bc72f4
Notes: sideshowbarker 2024-07-17 06:38:11 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/ad36bc72f4
Pull-request: https://github.com/SerenityOS/serenity/pull/16175
Reviewed-by: https://github.com/ADKaster
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Userland/Libraries/LibWeb/HTML/HTMLTableSectionElement.cpp
View File

@ -22,17 +22,24 @@ HTMLTableSectionElement::HTMLTableSectionElement(DOM::Document& document, DOM::Q
HTMLTableSectionElement::~HTMLTableSectionElement() = default;
void HTMLTableSectionElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_rows);
}
// https://html.spec.whatwg.org/multipage/tables.html#dom-tbody-rows
JS::NonnullGCPtr<DOM::HTMLCollection> HTMLTableSectionElement::rows() const
{
// The rows attribute must return an HTMLCollection rooted at this element,
// whose filter matches only tr elements that are children of this element.
// FIXME: This should return the same HTMLCollection object every time,
// but that would cause a reference cycle since HTMLCollection refs the root.
return DOM::HTMLCollection::create(const_cast<HTMLTableSectionElement&>(*this), [this](Element const& element) {
return element.parent() == this
&& is<HTMLTableRowElement>(element);
});
if (!m_rows) {
m_rows = DOM::HTMLCollection::create(const_cast<HTMLTableSectionElement&>(*this), [this](Element const& element) {
return element.parent() == this
&& is<HTMLTableRowElement>(element);
});
}
return *m_rows;
}
// https://html.spec.whatwg.org/multipage/tables.html#dom-tbody-insertrow

4
Userland/Libraries/LibWeb/HTML/HTMLTableSectionElement.h
View File

@ -23,6 +23,10 @@ public:
private:
HTMLTableSectionElement(DOM::Document&, DOM::QualifiedName);
virtual void visit_edges(Cell::Visitor&) override;
JS::GCPtr<DOM::HTMLCollection> mutable m_rows;
};
}