LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 05:25:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Kernel: Mark SDHC InterruptStatus structured view as const

Browse Source 
This view is really nice to check flags, but when clearing them we must
make sure that we only ever try to set 1 bit at a time, which makes
setting bits through the structured view a footgun, as that fetches,
ors in and then sets, potentially resetting other flags.
This commit is contained in:
Hendiadyoin1 2023-09-30 12:48:06 +02:00 committed by Andreas Kling
parent f51e8e785c
commit aea244efe1
Notes: sideshowbarker 2024-07-16 20:21:48 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/aea244efe1
Pull-request: https://github.com/SerenityOS/serenity/pull/21275
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Kernel/Devices/Storage/SD/Registers.h
View File

@ -103,7 +103,7 @@ struct HostControlRegisterMap {
u32 tuning_error : 1;
u32 response_error : 1;
u32 vendor_specific_error : 1;
};
} const;
u32 raw;
} interrupt_status;
u32 interrupt_status_enable;