mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 05:25:32 +03:00
Ladybird: Fix compilation on macOS/Clang
- Silences the -Wuser-defined-literals warning which is triggered by our use of the `sv` suffix for StringView - Removes an unused captured `this` pointer [-Wunused-lambda-capture] - Changes a JSONArray.h include to JSONObject.h to get the definition for `JSONValue::serialize`. This is needed because template functions are not exported for dylibs on macOS. This is a hack; the JSON headers should be refactored so that each one includes the definition of the template functions it sees. -- Maybe we should build with -fvisibility-inlines-hidden on Linux to catch issues like this?
This commit is contained in:
parent
d1d6a204fc
commit
af5250b2cb
Notes:
sideshowbarker
2024-07-17 02:48:03 +09:00
Author: https://github.com/BertalanD Commit: https://github.com/SerenityOS/serenity/commit/af5250b2cb Pull-request: https://github.com/SerenityOS/serenity/pull/16583 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/awesomekling ✅ Reviewed-by: https://github.com/linusg
@ -28,6 +28,7 @@ include(cmake/FetchLagom.cmake)
|
||||
# Lagom warnings
|
||||
include(${Lagom_SOURCE_DIR}/../CMake/lagom_compile_options.cmake)
|
||||
add_compile_options(-Wno-expansion-to-defined)
|
||||
add_compile_options(-Wno-user-defined-literals)
|
||||
|
||||
set(CMAKE_AUTOMOC ON)
|
||||
find_package(Qt6 REQUIRED COMPONENTS Core Widgets Network)
|
||||
|
@ -5,7 +5,7 @@
|
||||
*/
|
||||
|
||||
#include "RequestManagerQt.h"
|
||||
#include <AK/JsonArray.h>
|
||||
#include <AK/JsonObject.h>
|
||||
|
||||
RequestManagerQt::RequestManagerQt()
|
||||
{
|
||||
|
@ -53,7 +53,7 @@ Tab::Tab(QMainWindow* window)
|
||||
const QPoint* pos = new QPoint(0, size().height() - 15);
|
||||
QToolTip::showText(*pos, title, this);
|
||||
});
|
||||
QObject::connect(m_view, &WebView::linkUnhovered, [this] {
|
||||
QObject::connect(m_view, &WebView::linkUnhovered, [] {
|
||||
QToolTip::hideText();
|
||||
});
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user