LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-15 23:37:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Kernel/PCI: Prefer structured bindings when iterating over HashMaps

Browse Source 
This makes `Access::rescan_hardware` look a bit nicer.
This commit is contained in:
Hendiadyoin1 2024-03-01 14:21:10 +01:00 committed by Andrew Kaster
parent 2537efaf64
commit b0fc5bea91
Notes: sideshowbarker 2024-07-17 06:45:52 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/b0fc5bea91
Pull-request: https://github.com/SerenityOS/serenity/pull/23403
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Kernel/Bus/PCI/Access.cpp
View File

@ -162,8 +162,8 @@ UNMAP_AFTER_INIT void Access::rescan_hardware()
SpinlockLocker scan_locker(m_scan_lock);
VERIFY(m_device_identifiers.is_empty());
ErrorOr<void> error_or_void {};
for (auto it = m_host_controllers.begin(); it != m_host_controllers.end(); ++it) {
(*it).value->enumerate_attached_devices([this, &error_or_void](EnumerableDeviceIdentifier device_identifier) -> IterationDecision {
for (auto& [_, host_controller] : m_host_controllers) {
host_controller->enumerate_attached_devices([this, &error_or_void](EnumerableDeviceIdentifier device_identifier) -> IterationDecision {
auto device_identifier_or_error = DeviceIdentifier::from_enumerable_identifier(device_identifier);
if (device_identifier_or_error.is_error()) {
error_or_void = device_identifier_or_error.release_error();