From b2f707353910c0ea1fe45a56da4e640085d6a7b9 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 15 Jun 2024 21:04:55 -0400 Subject: [PATCH] LibLocale: Remove (now) needless explicit enum class underlying types This was useful for code generation as reducing the size of the enums had a notable impact on the size of the generated code. This is not the case any longer. --- Userland/Libraries/LibLocale/DateTimeFormat.h | 6 +++--- Userland/Libraries/LibLocale/Forward.h | 10 +++++----- Userland/Libraries/LibLocale/Locale.h | 2 +- Userland/Libraries/LibLocale/PluralRules.h | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Userland/Libraries/LibLocale/DateTimeFormat.h b/Userland/Libraries/LibLocale/DateTimeFormat.h index 137f45af3e9..9d7d12b432d 100644 --- a/Userland/Libraries/LibLocale/DateTimeFormat.h +++ b/Userland/Libraries/LibLocale/DateTimeFormat.h @@ -25,7 +25,7 @@ enum class DateTimeStyle { DateTimeStyle date_time_style_from_string(StringView); StringView date_time_style_to_string(DateTimeStyle); -enum class Weekday : u8 { +enum class Weekday { Sunday, Monday, Tuesday, @@ -35,7 +35,7 @@ enum class Weekday : u8 { Saturday, }; -enum class HourCycle : u8 { +enum class HourCycle { H11, H12, H23, @@ -45,7 +45,7 @@ HourCycle hour_cycle_from_string(StringView hour_cycle); StringView hour_cycle_to_string(HourCycle hour_cycle); Optional default_hour_cycle(StringView locale); -enum class CalendarPatternStyle : u8 { +enum class CalendarPatternStyle { Narrow, Short, Long, diff --git a/Userland/Libraries/LibLocale/Forward.h b/Userland/Libraries/LibLocale/Forward.h index e8e7c07bbbc..2e8c2c5a20b 100644 --- a/Userland/Libraries/LibLocale/Forward.h +++ b/Userland/Libraries/LibLocale/Forward.h @@ -10,11 +10,11 @@ namespace Locale { -enum class CalendarPatternStyle : u8; -enum class HourCycle : u8; -enum class PluralCategory : u8; -enum class Style : u8; -enum class Weekday : u8; +enum class CalendarPatternStyle; +enum class HourCycle; +enum class PluralCategory; +enum class Style; +enum class Weekday; class NumberFormat; diff --git a/Userland/Libraries/LibLocale/Locale.h b/Userland/Libraries/LibLocale/Locale.h index 17d5662c907..4aa4f18f67e 100644 --- a/Userland/Libraries/LibLocale/Locale.h +++ b/Userland/Libraries/LibLocale/Locale.h @@ -78,7 +78,7 @@ struct LocaleID { Vector private_use_extensions {}; }; -enum class Style : u8 { +enum class Style { Long, Short, Narrow, diff --git a/Userland/Libraries/LibLocale/PluralRules.h b/Userland/Libraries/LibLocale/PluralRules.h index 8b893b60c1c..87fbd9d6a2d 100644 --- a/Userland/Libraries/LibLocale/PluralRules.h +++ b/Userland/Libraries/LibLocale/PluralRules.h @@ -17,7 +17,7 @@ enum class PluralForm { PluralForm plural_form_from_string(StringView); StringView plural_form_to_string(PluralForm); -enum class PluralCategory : u8 { +enum class PluralCategory { Other, Zero, One,