LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add support for the record variant of URLSearchParams

Browse Source
This commit is contained in:
Luke Wilde 2022-02-14 06:38:03 +00:00 committed by Andreas Kling
parent b7c435de17
commit b305ee8692
Notes: sideshowbarker 2024-07-17 18:52:22 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/b305ee8692
Pull-request: https://github.com/SerenityOS/serenity/pull/12509
3 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Userland/Libraries/LibWeb/URL/URLSearchParams.cpp
View File

@ -66,7 +66,9 @@ Vector<QueryParam> url_decode(StringView input)
return output;
}
DOM::ExceptionOr<NonnullRefPtr<URLSearchParams>> URLSearchParams::create_with_global_object(Bindings::WindowObject&, Variant<Vector<Vector<String>>, String> const& init)
// https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams
// https://url.spec.whatwg.org/#urlsearchparams-initialize
DOM::ExceptionOr<NonnullRefPtr<URLSearchParams>> URLSearchParams::create_with_global_object(Bindings::WindowObject&, Variant<Vector<Vector<String>>, OrderedHashMap<String, String>, String> const& init)
{
// 1. If init is a string and starts with U+003F (?), then remove the first code point from init.
// NOTE: We do this when we know that it's a string on step 3 of initialization.
@ -94,8 +96,18 @@ DOM::ExceptionOr<NonnullRefPtr<URLSearchParams>> URLSearchParams::create_with_gl
return URLSearchParams::create(move(list));
}
// TODO
// 2. Otherwise, if init is a record, then for each name → value of init, append a new name-value pair whose name is name and value is value, to query’s list.
if (init.has<OrderedHashMap<String, String>>()) {
auto const& init_record = init.get<OrderedHashMap<String, String>>();
Vector<QueryParam> list;
list.ensure_capacity(init_record.size());
for (auto const& pair : init_record)
list.append(QueryParam { .name = pair.key, .value = pair.value });
return URLSearchParams::create(move(list));
}
// 3. Otherwise:
// a. Assert: init is a string.

2
Userland/Libraries/LibWeb/URL/URLSearchParams.h
View File

@ -30,7 +30,7 @@ public:
return adopt_ref(*new URLSearchParams(move(list)));
}
static DOM::ExceptionOr<NonnullRefPtr<URLSearchParams>> create_with_global_object(Bindings::WindowObject&, Variant<Vector<Vector<String>>, String> const& init);
static DOM::ExceptionOr<NonnullRefPtr<URLSearchParams>> create_with_global_object(Bindings::WindowObject&, Variant<Vector<Vector<String>>, OrderedHashMap<String, String>, String> const& init);
void append(String const& name, String const& value);
void delete_(String const& name);

3
Userland/Libraries/LibWeb/URL/URLSearchParams.idl
View File

@ -1,7 +1,6 @@
interface URLSearchParams {
// FIXME: the real type of init is (sequence<sequence<USVString>> or record<USVString, USVString> or USVString)
constructor(optional (sequence<sequence<USVString>> or USVString) init = "");
constructor(optional (sequence<sequence<USVString>> or record<USVString, USVString> or USVString) init = "");
undefined append(USVString name, USVString value);
undefined delete(USVString name);