LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 01:08:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove ByteString usage in input element placeholder_value()

Browse Source
This commit is contained in:
Bastiaan van der Plaat 2024-03-15 17:40:40 +01:00 committed by Tim Flynn
parent 3fd1164171
commit b4bae912c9
Notes: sideshowbarker 2024-07-17 03:18:29 +09:00 
Author: https://github.com/bplaat
Commit: https://github.com/SerenityOS/serenity/commit/b4bae912c9
Pull-request: https://github.com/SerenityOS/serenity/pull/23551
Reviewed-by: https://github.com/trflynn89
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@ -689,7 +689,7 @@ String HTMLInputElement::placeholder() const
}
// https://html.spec.whatwg.org/multipage/input.html#attr-input-placeholder
Optional<ByteString> HTMLInputElement::placeholder_value() const
Optional<String> HTMLInputElement::placeholder_value() const
{
if (!m_text_node || !m_text_node->data().is_empty())
return {};
@ -697,7 +697,7 @@ Optional<ByteString> HTMLInputElement::placeholder_value() const
return {};
if (!has_attribute(HTML::AttributeNames::placeholder))
return {};
return placeholder().to_byte_string();
return placeholder();
}
void HTMLInputElement::create_shadow_tree_if_needed()

2
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View File

@ -79,7 +79,7 @@ public:
void commit_pending_changes();
String placeholder() const;
Optional<ByteString> placeholder_value() const;
Optional<String> placeholder_value() const;
bool checked() const { return m_checked; }
enum class ChangeSource {