LibJS: Implement Temporal.Instant.prototype.epochMicroseconds

This commit is contained in:
Linus Groh 2021-07-08 22:11:51 +01:00
parent b157ab3f12
commit b5d0cdc97e
Notes: sideshowbarker 2024-07-18 10:02:35 +09:00
4 changed files with 56 additions and 0 deletions

View File

@ -113,6 +113,7 @@ namespace JS {
P(endsWith) \
P(entries) \
P(enumerable) \
P(epochMicroseconds) \
P(epochMilliseconds) \
P(epochSeconds) \
P(error) \

View File

@ -25,6 +25,7 @@ void InstantPrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.epochSeconds, epoch_seconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.epochMilliseconds, epoch_milliseconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.epochMicroseconds, epoch_microseconds_getter, {}, Attribute::Configurable);
// 8.3.2 Temporal.Instant.prototype[ @@toStringTag ], https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype-@@tostringtag
define_direct_property(*vm.well_known_symbol_to_string_tag(), js_string(vm.heap(), "Temporal.Instant"), Attribute::Configurable);
@ -81,4 +82,23 @@ JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::epoch_milliseconds_getter)
return Value((double)ms.to_base(10).to_int<i64>().value());
}
// 8.3.5 get Temporal.Instant.prototype.epochMicroseconds, https://tc39.es/proposal-temporal/#sec-get-temporal.instant.prototype.epochmicroseconds
JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::epoch_microseconds_getter)
{
// 1. Let instant be the this value.
// 2. Perform ? RequireInternalSlot(instant, [[InitializedTemporalInstant]]).
auto* instant = typed_this(global_object);
if (vm.exception())
return {};
// 3. Let ns be instant.[[Nanoseconds]].
auto& ns = instant->nanoseconds();
// 4. Let µs be RoundTowardsZero((ns) / 10^3).
auto [us, _] = ns.big_integer().divided_by(Crypto::SignedBigInteger::create_from(1'000));
// 5. Return (µs).
return js_bigint(vm.heap(), move(us));
}
}

View File

@ -21,6 +21,7 @@ public:
private:
JS_DECLARE_NATIVE_FUNCTION(epoch_seconds_getter);
JS_DECLARE_NATIVE_FUNCTION(epoch_milliseconds_getter);
JS_DECLARE_NATIVE_FUNCTION(epoch_microseconds_getter);
};
}

View File

@ -0,0 +1,34 @@
describe("correct behavior", () => {
test("basic functionality", () => {
expect(new Temporal.Instant(0n).epochMicroseconds).toBe(0n);
expect(new Temporal.Instant(1n).epochMicroseconds).toBe(0n);
expect(new Temporal.Instant(999n).epochMicroseconds).toBe(0n);
expect(new Temporal.Instant(1_000n).epochMicroseconds).toBe(1n);
expect(new Temporal.Instant(1_500n).epochMicroseconds).toBe(1n);
expect(new Temporal.Instant(1_999n).epochMicroseconds).toBe(1n);
expect(new Temporal.Instant(2_000n).epochMicroseconds).toBe(2n);
expect(new Temporal.Instant(8_640_000_000_000_000_000_000n).epochMicroseconds).toBe(
8_640_000_000_000_000_000n
);
// FIXME: These seemingly produce correct results in js(1s), but for some reason don't pass. Investigate.
// expect(new Temporal.Instant(-0n).epochMicroseconds).toBe(-0n);
// expect(new Temporal.Instant(-1n).epochMicroseconds).toBe(-0n);
// expect(new Temporal.Instant(-999n).epochMicroseconds).toBe(-0n);
expect(new Temporal.Instant(-1_000n).epochMicroseconds).toBe(-1n);
expect(new Temporal.Instant(-1_500n).epochMicroseconds).toBe(-1n);
expect(new Temporal.Instant(-1_999n).epochMicroseconds).toBe(-1n);
expect(new Temporal.Instant(-2_000n).epochMicroseconds).toBe(-2n);
expect(new Temporal.Instant(-8_640_000_000_000_000_000_000n).epochMicroseconds).toBe(
-8_640_000_000_000_000_000n
);
});
});
test("errors", () => {
test("this value must be a Temporal.Instant object", () => {
expect(() => {
Reflect.get(Temporal.Instant.prototype, "epochMicroseconds", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.Instant");
});
});