LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

TextEditor: Clear the selection before deleting it

Browse Source 
This patches fixes a crash of the Userland/TextEditor where it would
crash when deleting a range spanning two lines. This was because the
TextEditor would delete the range and modify the cursor position
before clearing the selection. This would trigger a status bar update
with the invalid selection.
This commit is contained in:
Paul Berg 2021-05-02 18:33:31 +02:00 committed by Andreas Kling
parent 97d0028098
commit bd68ca362b
Notes: sideshowbarker 2024-07-18 18:45:09 +09:00 
Author: https://github.com/Pangoraw
Commit: https://github.com/SerenityOS/serenity/commit/bd68ca362bd
Pull-request: https://github.com/SerenityOS/serenity/pull/6818
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibGUI/TextEditor.cpp
View File

@ -1220,8 +1220,9 @@ String TextEditor::selected_text() const
void TextEditor::delete_selection()
{
auto selection = normalized_selection();
execute<RemoveTextCommand>(selected_text(), selection);
auto selected = selected_text();
m_selection.clear();
execute<RemoveTextCommand>(selected, selection);
did_update_selection();
did_change();
set_cursor(selection.start());