LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 05:25:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Set script force async to false when async changes

Browse Source
This commit is contained in:
Jamie Mansfield 2024-08-04 19:06:07 +01:00 committed by Tim Ledbetter
parent 77c41a82be
commit bedb626c29
Notes: github-actions[bot] 2024-08-04 18:26:23 +00:00 
Author: https://github.com/jamierocks
Commit: https://github.com/LadybirdBrowser/ladybird/commit/bedb626c299
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/961
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/script-async-attribute.txt
View File

@ -1,2 +1,3 @@
includeScript.async = false
script.async = true
script.async = false

4
Tests/LibWeb/Text/input/HTML/script-async-attribute.html
View File

@ -7,5 +7,9 @@
const script = document.createElement("script");
println(`script.async = ${script.async}`);
script.setAttribute("async", "true");
script.removeAttribute("async");
println(`script.async = ${script.async}`);
});
</script>

4
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View File

@ -66,6 +66,10 @@ void HTMLScriptElement::attribute_changed(FlyString const& name, Optional<String
if (!is_parser_inserted() && is_connected() && value.has_value() && !old_value.has_value()) {
prepare_script();
}
} else if (name == HTML::AttributeNames::async) {
// https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:script-force-async
// When an async attribute is added to a script element el, the user agent must set el's force async to false.
m_force_async = false;
}
}