From bf1f631f257e90e91b0b45a6454d731b4b98914c Mon Sep 17 00:00:00 2001
From: Daniel Bertalan <dani@danielbertalan.dev>
Date: Sun, 16 Jun 2024 10:38:35 +0200
Subject: [PATCH] Everywhere: Write dtors for types with incomplete members
 out-of-line

These are rejected by Clang (19) trunk as a result of
https://github.com/llvm/llvm-project/pull/77753.
---
 Userland/Libraries/LibCore/NetworkJob.cpp                     | 2 ++
 Userland/Libraries/LibCore/NetworkJob.h                       | 2 +-
 Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp        | 2 ++
 Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h          | 2 +-
 Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp     | 2 ++
 Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h       | 2 +-
 Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp         | 2 ++
 Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h           | 2 +-
 Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp       | 2 ++
 Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h         | 2 +-
 Userland/Libraries/LibJS/CyclicModule.cpp                     | 2 ++
 Userland/Libraries/LibJS/CyclicModule.h                       | 2 ++
 Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp           | 2 ++
 Userland/Libraries/LibJS/Runtime/AsyncGenerator.h             | 2 +-
 Userland/Libraries/LibJS/SourceTextModule.cpp                 | 2 ++
 Userland/Libraries/LibJS/SourceTextModule.h                   | 2 ++
 Userland/Libraries/LibProtocol/RequestClient.cpp              | 2 ++
 Userland/Libraries/LibProtocol/RequestClient.h                | 1 +
 Userland/Libraries/LibWeb/CSS/FontFace.cpp                    | 2 ++
 Userland/Libraries/LibWeb/CSS/FontFace.h                      | 2 +-
 Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp | 2 ++
 Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h   | 2 +-
 Userland/Services/WebContent/ConnectionFromClient.cpp         | 2 ++
 Userland/Services/WebContent/ConnectionFromClient.h           | 2 +-
 Userland/Services/WebContent/PageClient.cpp                   | 2 ++
 Userland/Services/WebContent/PageClient.h                     | 2 ++
 26 files changed, 42 insertions(+), 9 deletions(-)

diff --git a/Userland/Libraries/LibCore/NetworkJob.cpp b/Userland/Libraries/LibCore/NetworkJob.cpp
index 9ff275d8e69..cb72a44f94d 100644
--- a/Userland/Libraries/LibCore/NetworkJob.cpp
+++ b/Userland/Libraries/LibCore/NetworkJob.cpp
@@ -16,6 +16,8 @@ NetworkJob::NetworkJob(Stream& output_stream)
 {
 }
 
+NetworkJob::~NetworkJob() = default;
+
 void NetworkJob::did_finish(NonnullRefPtr<NetworkResponse>&& response)
 {
     if (is_cancelled())
diff --git a/Userland/Libraries/LibCore/NetworkJob.h b/Userland/Libraries/LibCore/NetworkJob.h
index e8df3e38c9b..0cc1545a056 100644
--- a/Userland/Libraries/LibCore/NetworkJob.h
+++ b/Userland/Libraries/LibCore/NetworkJob.h
@@ -25,7 +25,7 @@ public:
         ProtocolFailed,
         Cancelled,
     };
-    virtual ~NetworkJob() override = default;
+    virtual ~NetworkJob() override;
 
     // Could fire twice, after Headers and after Trailers!
     Function<void(HTTP::HeaderMap const& response_headers, Optional<u32> response_code)> on_headers_received;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp
index f2ceef824eb..14c45ab867a 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp
+++ b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp
@@ -2627,6 +2627,8 @@ JBIG2ImageDecoderPlugin::JBIG2ImageDecoderPlugin()
     m_context = make<JBIG2LoadingContext>();
 }
 
+JBIG2ImageDecoderPlugin::~JBIG2ImageDecoderPlugin() = default;
+
 IntSize JBIG2ImageDecoderPlugin::size()
 {
     return m_context->page.size;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h
index 1841ed8be6d..7bcdfb79c11 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h
+++ b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h
@@ -19,7 +19,7 @@ public:
     static bool sniff(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
 
-    virtual ~JBIG2ImageDecoderPlugin() override = default;
+    virtual ~JBIG2ImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp
index 19a570a6cec..752b37c9369 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp
+++ b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp
@@ -988,6 +988,8 @@ JPEG2000ImageDecoderPlugin::JPEG2000ImageDecoderPlugin()
     m_context = make<JPEG2000LoadingContext>();
 }
 
+JPEG2000ImageDecoderPlugin::~JPEG2000ImageDecoderPlugin() = default;
+
 IntSize JPEG2000ImageDecoderPlugin::size()
 {
     return m_context->size;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h
index a1f8136fa92..0d8c6450b5e 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h
+++ b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h
@@ -37,7 +37,7 @@ public:
     static bool sniff(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
 
-    virtual ~JPEG2000ImageDecoderPlugin() override = default;
+    virtual ~JPEG2000ImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
index 3b8f6e0b965..693502877ef 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
+++ b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
@@ -748,6 +748,8 @@ TIFFImageDecoderPlugin::TIFFImageDecoderPlugin(NonnullOwnPtr<FixedMemoryStream>
     m_context = make<TIFF::TIFFLoadingContext>(move(stream));
 }
 
+TIFFImageDecoderPlugin::~TIFFImageDecoderPlugin() = default;
+
 bool TIFFImageDecoderPlugin::sniff(ReadonlyBytes bytes)
 {
     if (bytes.size() < 4)
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h
index 02847a2e2ba..177306e4164 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h
+++ b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h
@@ -38,7 +38,7 @@ public:
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ExifMetadata>> read_exif_metadata(ReadonlyBytes);
 
-    virtual ~TIFFImageDecoderPlugin() override = default;
+    virtual ~TIFFImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp
index f9bd18c4713..9d63684e240 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp
+++ b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp
@@ -550,6 +550,8 @@ TinyVGImageDecoderPlugin::TinyVGImageDecoderPlugin(ReadonlyBytes bytes)
 {
 }
 
+TinyVGImageDecoderPlugin::~TinyVGImageDecoderPlugin() = default;
+
 ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> TinyVGImageDecoderPlugin::create(ReadonlyBytes bytes)
 {
     auto plugin = TRY(adopt_nonnull_own_or_enomem(new (nothrow) TinyVGImageDecoderPlugin(bytes)));
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h
index 5ea7a4aa521..8ca323741a9 100644
--- a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h
+++ b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h
@@ -86,7 +86,7 @@ public:
     virtual NaturalFrameFormat natural_frame_format() const override { return NaturalFrameFormat::Vector; }
     virtual ErrorOr<VectorImageFrameDescriptor> vector_frame(size_t index) override;
 
-    virtual ~TinyVGImageDecoderPlugin() override = default;
+    virtual ~TinyVGImageDecoderPlugin() override;
 
 private:
     TinyVGImageDecoderPlugin(ReadonlyBytes);
diff --git a/Userland/Libraries/LibJS/CyclicModule.cpp b/Userland/Libraries/LibJS/CyclicModule.cpp
index 8bf8aa39fd2..9fd15a9049c 100644
--- a/Userland/Libraries/LibJS/CyclicModule.cpp
+++ b/Userland/Libraries/LibJS/CyclicModule.cpp
@@ -24,6 +24,8 @@ CyclicModule::CyclicModule(Realm& realm, StringView filename, bool has_top_level
 {
 }
 
+CyclicModule::~CyclicModule() = default;
+
 void CyclicModule::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/CyclicModule.h b/Userland/Libraries/LibJS/CyclicModule.h
index aa4fd024d75..c0fa90df8e6 100644
--- a/Userland/Libraries/LibJS/CyclicModule.h
+++ b/Userland/Libraries/LibJS/CyclicModule.h
@@ -28,6 +28,8 @@ class CyclicModule : public Module {
     JS_DECLARE_ALLOCATOR(CyclicModule);
 
 public:
+    virtual ~CyclicModule() override;
+
     // Note: Do not call these methods directly unless you are HostResolveImportedModule.
     //       Badges cannot be used because other hosts must be able to call this (and it is called recursively)
     virtual ThrowCompletionOr<void> link(VM& vm) override final;
diff --git a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp
index 94fdd774819..74e8e985f83 100644
--- a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp
+++ b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp
@@ -34,6 +34,8 @@ AsyncGenerator::AsyncGenerator(Realm&, Object& prototype, NonnullOwnPtr<Executio
 {
 }
 
+AsyncGenerator::~AsyncGenerator() = default;
+
 void AsyncGenerator::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h
index db980ce452f..f2f9cffc7ea 100644
--- a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h
+++ b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h
@@ -30,7 +30,7 @@ public:
 
     static ThrowCompletionOr<NonnullGCPtr<AsyncGenerator>> create(Realm&, Value, ECMAScriptFunctionObject*, NonnullOwnPtr<ExecutionContext>);
 
-    virtual ~AsyncGenerator() override = default;
+    virtual ~AsyncGenerator() override;
 
     void async_generator_enqueue(Completion, NonnullGCPtr<PromiseCapability>);
     ThrowCompletionOr<void> resume(VM&, Completion completion);
diff --git a/Userland/Libraries/LibJS/SourceTextModule.cpp b/Userland/Libraries/LibJS/SourceTextModule.cpp
index eaf04a23e16..b50c671ca21 100644
--- a/Userland/Libraries/LibJS/SourceTextModule.cpp
+++ b/Userland/Libraries/LibJS/SourceTextModule.cpp
@@ -116,6 +116,8 @@ SourceTextModule::SourceTextModule(Realm& realm, StringView filename, Script::Ho
 {
 }
 
+SourceTextModule::~SourceTextModule() = default;
+
 void SourceTextModule::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/SourceTextModule.h b/Userland/Libraries/LibJS/SourceTextModule.h
index 2069495d23d..5ab4717eea1 100644
--- a/Userland/Libraries/LibJS/SourceTextModule.h
+++ b/Userland/Libraries/LibJS/SourceTextModule.h
@@ -19,6 +19,8 @@ class SourceTextModule final : public CyclicModule {
     JS_DECLARE_ALLOCATOR(SourceTextModule);
 
 public:
+    virtual ~SourceTextModule() override;
+
     static Result<NonnullGCPtr<SourceTextModule>, Vector<ParserError>> parse(StringView source_text, Realm&, StringView filename = {}, Script::HostDefined* host_defined = nullptr);
 
     Program const& parse_node() const { return *m_ecmascript_code; }
diff --git a/Userland/Libraries/LibProtocol/RequestClient.cpp b/Userland/Libraries/LibProtocol/RequestClient.cpp
index 835226b98f8..2fa3e35c927 100644
--- a/Userland/Libraries/LibProtocol/RequestClient.cpp
+++ b/Userland/Libraries/LibProtocol/RequestClient.cpp
@@ -14,6 +14,8 @@ RequestClient::RequestClient(NonnullOwnPtr<Core::LocalSocket> socket)
 {
 }
 
+RequestClient::~RequestClient() = default;
+
 void RequestClient::die()
 {
     // FIXME: Gracefully handle this, or relaunch and reconnect to RequestServer.
diff --git a/Userland/Libraries/LibProtocol/RequestClient.h b/Userland/Libraries/LibProtocol/RequestClient.h
index fbb1c79a3bb..b4e282692a8 100644
--- a/Userland/Libraries/LibProtocol/RequestClient.h
+++ b/Userland/Libraries/LibProtocol/RequestClient.h
@@ -25,6 +25,7 @@ class RequestClient final
 
 public:
     explicit RequestClient(NonnullOwnPtr<Core::LocalSocket>);
+    virtual ~RequestClient() override;
 
     RefPtr<Request> start_request(ByteString const& method, URL::URL const&, HTTP::HeaderMap const& request_headers = {}, ReadonlyBytes request_body = {}, Core::ProxyData const& = {});
 
diff --git a/Userland/Libraries/LibWeb/CSS/FontFace.cpp b/Userland/Libraries/LibWeb/CSS/FontFace.cpp
index a21307420ea..c9ace000050 100644
--- a/Userland/Libraries/LibWeb/CSS/FontFace.cpp
+++ b/Userland/Libraries/LibWeb/CSS/FontFace.cpp
@@ -198,6 +198,8 @@ FontFace::FontFace(JS::Realm& realm, JS::NonnullGCPtr<WebIDL::Promise> font_stat
         m_status = Bindings::FontFaceLoadStatus::Error;
 }
 
+FontFace::~FontFace() = default;
+
 void FontFace::initialize(JS::Realm& realm)
 {
     Base::initialize(realm);
diff --git a/Userland/Libraries/LibWeb/CSS/FontFace.h b/Userland/Libraries/LibWeb/CSS/FontFace.h
index c5cb69a9272..1bf5661374e 100644
--- a/Userland/Libraries/LibWeb/CSS/FontFace.h
+++ b/Userland/Libraries/LibWeb/CSS/FontFace.h
@@ -35,7 +35,7 @@ public:
     using FontFaceSource = Variant<String, JS::Handle<WebIDL::BufferSource>>;
 
     [[nodiscard]] static JS::NonnullGCPtr<FontFace> construct_impl(JS::Realm&, String family, FontFaceSource source, FontFaceDescriptors const& descriptors);
-    virtual ~FontFace() override = default;
+    virtual ~FontFace() override;
 
     String family() const { return m_family; }
     WebIDL::ExceptionOr<void> set_family(String const&);
diff --git a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp
index 991f04096c7..9c7d9c6e368 100644
--- a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp
+++ b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp
@@ -26,6 +26,8 @@ ImageStyleValue::ImageStyleValue(URL::URL const& url)
 {
 }
 
+ImageStyleValue::~ImageStyleValue() = default;
+
 void ImageStyleValue::load_any_resources(DOM::Document& document)
 {
     if (m_image_request)
diff --git a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h
index a67467cdf43..79c9656b444 100644
--- a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h
+++ b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h
@@ -26,7 +26,7 @@ public:
     {
         return adopt_ref(*new (nothrow) ImageStyleValue(url));
     }
-    virtual ~ImageStyleValue() override = default;
+    virtual ~ImageStyleValue() override;
 
     void visit_edges(JS::Cell::Visitor& visitor) const
     {
diff --git a/Userland/Services/WebContent/ConnectionFromClient.cpp b/Userland/Services/WebContent/ConnectionFromClient.cpp
index 4fcfa6cdf03..45c20f534d6 100644
--- a/Userland/Services/WebContent/ConnectionFromClient.cpp
+++ b/Userland/Services/WebContent/ConnectionFromClient.cpp
@@ -58,6 +58,8 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::LocalSocket> sock
     async_notify_process_information({ ::getpid() });
 }
 
+ConnectionFromClient::~ConnectionFromClient() = default;
+
 void ConnectionFromClient::die()
 {
     Web::Platform::EventLoopPlugin::the().quit();
diff --git a/Userland/Services/WebContent/ConnectionFromClient.h b/Userland/Services/WebContent/ConnectionFromClient.h
index 0c638d63ed2..3c587b8fee1 100644
--- a/Userland/Services/WebContent/ConnectionFromClient.h
+++ b/Userland/Services/WebContent/ConnectionFromClient.h
@@ -33,7 +33,7 @@ class ConnectionFromClient final
     C_OBJECT(ConnectionFromClient);
 
 public:
-    ~ConnectionFromClient() override = default;
+    ~ConnectionFromClient() override;
 
     virtual void die() override;
 
diff --git a/Userland/Services/WebContent/PageClient.cpp b/Userland/Services/WebContent/PageClient.cpp
index c7294a9b6ae..21772acbbf0 100644
--- a/Userland/Services/WebContent/PageClient.cpp
+++ b/Userland/Services/WebContent/PageClient.cpp
@@ -70,6 +70,8 @@ PageClient::PageClient(PageHost& owner, u64 id)
 #endif
 }
 
+PageClient::~PageClient() = default;
+
 void PageClient::schedule_repaint()
 {
     if (m_paint_state != PaintState::Ready) {
diff --git a/Userland/Services/WebContent/PageClient.h b/Userland/Services/WebContent/PageClient.h
index 9f13f6e38dd..77e2d801fd9 100644
--- a/Userland/Services/WebContent/PageClient.h
+++ b/Userland/Services/WebContent/PageClient.h
@@ -29,6 +29,8 @@ class PageClient final : public Web::PageClient {
 public:
     static JS::NonnullGCPtr<PageClient> create(JS::VM& vm, PageHost& page_host, u64 id);
 
+    virtual ~PageClient() override;
+
     static void set_use_gpu_painter();
     static void set_use_experimental_cpu_transform_support();