LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-10-03 16:48:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/Geometry: Make DOMRect doubles unrestricted

Browse Source
This commit is contained in:
Bastiaan van der Plaat 2024-07-01 21:12:26 +02:00 committed by Tim Ledbetter
parent 55c1b5d1f4
commit bff6c0680a
Notes: sideshowbarker 2024-07-16 23:34:49 +09:00 
Author: https://github.com/bplaat
Commit: https://github.com/LadybirdBrowser/ladybird/commit/bff6c0680a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/337
Reviewed-by: https://github.com/tcl3 ✅
5 changed files with 36 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
Tests/LibWeb/Text/expected/geometry/domrect-create.txt
View File

@ -3,24 +3,24 @@ Testing DOMRect:
2. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10} 2. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10}
3. {"x":-10,"y":-20,"width":30,"height":40,"top":-20,"right":20,"bottom":20,"left":-10} 3. {"x":-10,"y":-20,"width":30,"height":40,"top":-20,"right":20,"bottom":20,"left":-10}
4. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10} 4. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10}
5. Exception: TypeError 5. {"x":null,"y":20,"width":30,"height":40,"top":20,"right":null,"bottom":60,"left":null}
6. Exception: TypeError 6. {"x":10,"y":null,"width":30,"height":40,"top":null,"right":40,"bottom":null,"left":10}
7. Exception: TypeError 7. {"x":10,"y":20,"width":null,"height":40,"top":20,"right":null,"bottom":60,"left":null}
8. Exception: TypeError 8. {"x":10,"y":20,"width":30,"height":null,"top":null,"right":40,"bottom":null,"left":10}
9. Exception: TypeError 9. {"x":null,"y":20,"width":30,"height":40,"top":20,"right":null,"bottom":60,"left":null}
10. Exception: TypeError 10. {"x":10,"y":null,"width":30,"height":40,"top":null,"right":40,"bottom":null,"left":10}
11. Exception: TypeError 11. {"x":10,"y":20,"width":null,"height":40,"top":20,"right":null,"bottom":60,"left":10}
12. Exception: TypeError 12. {"x":10,"y":20,"width":30,"height":null,"top":20,"right":40,"bottom":null,"left":10}
Testing DOMRectReadOnly: Testing DOMRectReadOnly:
1. {"x":0,"y":0,"width":0,"height":0,"top":0,"right":0,"bottom":0,"left":0} 1. {"x":0,"y":0,"width":0,"height":0,"top":0,"right":0,"bottom":0,"left":0}
2. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10} 2. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10}
3. {"x":-10,"y":-20,"width":30,"height":40,"top":-20,"right":20,"bottom":20,"left":-10} 3. {"x":-10,"y":-20,"width":30,"height":40,"top":-20,"right":20,"bottom":20,"left":-10}
4. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10} 4. {"x":10,"y":20,"width":30,"height":40,"top":20,"right":40,"bottom":60,"left":10}
5. Exception: TypeError 5. {"x":null,"y":20,"width":30,"height":40,"top":20,"right":null,"bottom":60,"left":null}
6. Exception: TypeError 6. {"x":10,"y":null,"width":30,"height":40,"top":null,"right":40,"bottom":null,"left":10}
7. Exception: TypeError 7. {"x":10,"y":20,"width":null,"height":40,"top":20,"right":null,"bottom":60,"left":null}
8. Exception: TypeError 8. {"x":10,"y":20,"width":30,"height":null,"top":null,"right":40,"bottom":null,"left":10}
9. Exception: TypeError 9. {"x":null,"y":20,"width":30,"height":40,"top":20,"right":null,"bottom":60,"left":null}
10. Exception: TypeError 10. {"x":10,"y":null,"width":30,"height":40,"top":null,"right":40,"bottom":null,"left":10}
11. Exception: TypeError 11. {"x":10,"y":20,"width":null,"height":40,"top":20,"right":null,"bottom":60,"left":10}
12. Exception: TypeError 12. {"x":10,"y":20,"width":30,"height":null,"top":20,"right":40,"bottom":null,"left":10}

2
Tests/LibWeb/Text/input/geometry/domrect-create.html
View File

@ -13,7 +13,7 @@
for (const Rect of [DOMRect, DOMRectReadOnly]) { for (const Rect of [DOMRect, DOMRectReadOnly]) {
println(`Testing ${Rect.name}:`); println(`Testing ${Rect.name}:`);
// 1. Creating a DOMRect with no arguments // 1. Creating a DOMRect with no arguments
testPart(() => new Rect()); testPart(() => new Rect());

2
Userland/Libraries/LibWeb/Geometry/DOMQuad.cpp
View File

@ -62,12 +62,14 @@ JS::NonnullGCPtr<DOMQuad> DOMQuad::from_quad(JS::VM& vm, DOMQuadInit const& othe
// https://drafts.fxtf.org/geometry/#dom-domquad-getbounds // https://drafts.fxtf.org/geometry/#dom-domquad-getbounds
JS::NonnullGCPtr<DOMRect> DOMQuad::get_bounds() const JS::NonnullGCPtr<DOMRect> DOMQuad::get_bounds() const
{ {
// The NaN-safe minimum of a non-empty list of unrestricted double values is NaN if any member of the list is NaN, or the minimum of the list otherwise.
auto nan_safe_minimum = [](double a, double b, double c, double d) -> double { auto nan_safe_minimum = [](double a, double b, double c, double d) -> double {
if (isnan(a) || isnan(b) || isnan(c) || isnan(d)) if (isnan(a) || isnan(b) || isnan(c) || isnan(d))
return NAN; return NAN;
return min(a, min(b, min(c, d))); return min(a, min(b, min(c, d)));
}; };
// Analogously, the NaN-safe maximum of a non-empty list of unrestricted double values is NaN if any member of the list is NaN, or the maximum of the list otherwise.
auto nan_safe_maximum = [](double a, double b, double c, double d) -> double { auto nan_safe_maximum = [](double a, double b, double c, double d) -> double {
if (isnan(a) || isnan(b) || isnan(c) || isnan(d)) if (isnan(a) || isnan(b) || isnan(c) || isnan(d))
return NAN; return NAN;

13
Userland/Libraries/LibWeb/Geometry/DOMRect.idl
View File

@ -3,14 +3,13 @@
// https://drafts.fxtf.org/geometry/#dompoint // https://drafts.fxtf.org/geometry/#dompoint
[Exposed=(Window,Worker), Serializable, LegacyWindowAlias=SVGRect] [Exposed=(Window,Worker), Serializable, LegacyWindowAlias=SVGRect]
interface DOMRect : DOMRectReadOnly { interface DOMRect : DOMRectReadOnly {
constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
constructor(optional double x = 0, optional double y = 0, optional double width = 0, optional double height = 0); optional unrestricted double width = 0, optional unrestricted double height = 0);
[NewObject] static DOMRect fromRect(optional DOMRectInit other = {}); [NewObject] static DOMRect fromRect(optional DOMRectInit other = {});
attribute double x; attribute unrestricted double x;
attribute double y; attribute unrestricted double y;
attribute double width; attribute unrestricted double width;
attribute double height; attribute unrestricted double height;
}; };

22
Userland/Libraries/LibWeb/Geometry/DOMRectReadOnly.idl
View File

@ -1,25 +1,25 @@
// https://drafts.fxtf.org/geometry/#domrectreadonly // https://drafts.fxtf.org/geometry/#domrectreadonly
[Exposed=(Window, Worker), Serializable] [Exposed=(Window, Worker), Serializable]
interface DOMRectReadOnly { interface DOMRectReadOnly {
constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
constructor(optional double x = 0, optional double y = 0, optional double width = 0, optional double height = 0); optional unrestricted double width = 0, optional unrestricted double height = 0);
[NewObject] static DOMRectReadOnly fromRect(optional DOMRectInit other = {}); [NewObject] static DOMRectReadOnly fromRect(optional DOMRectInit other = {});
readonly attribute double x; readonly attribute unrestricted double x;
readonly attribute double y; readonly attribute unrestricted double y;
readonly attribute double width; readonly attribute unrestricted double width;
readonly attribute double height; readonly attribute unrestricted double height;
readonly attribute double top; readonly attribute unrestricted double top;
readonly attribute double right; readonly attribute unrestricted double right;
readonly attribute double bottom; readonly attribute unrestricted double bottom;
readonly attribute double left; readonly attribute unrestricted double left;
[Default] object toJSON(); [Default] object toJSON();
}; };
// https://drafts.fxtf.org/geometry/#dictdef-domrectinit
dictionary DOMRectInit { dictionary DOMRectInit {
unrestricted double x = 0; unrestricted double x = 0;
unrestricted double y = 0; unrestricted double y = 0;