LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-07 19:57:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Sever parent/child connections in ~TreeNode()

Browse Source 
Also make sure to unref the children if there are any. Without this
it was very easy to leak TreeNodes.
This commit is contained in:
Andreas Kling 2021-04-06 15:50:47 +02:00
parent 41e5a0fe02
commit c70e0a4f29
Notes: sideshowbarker 2024-07-18 20:43:50 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/c70e0a4f294
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Userland/Libraries/LibWeb/TreeNode.h
View File

@ -299,6 +299,17 @@ public:
return nullptr;
}
~TreeNode()
{
VERIFY(!m_parent);
T* next_child = nullptr;
for (auto* child = m_first_child; child; child = next_child) {
next_child = child->m_next_sibling;
child->m_parent = nullptr;
child->unref();
}
}
protected:
TreeNode() { }