mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-10-26 06:49:12 +03:00
Ladybird/QT: Avoid constructing AK String types from char* without size
While QByteArray::data does return a null-terminated char* it's nicer to avoid strlen() when we already know the size
This commit is contained in:
parent
d18f7145ad
commit
cac23820c5
Notes:
sideshowbarker
2024-07-17 08:35:21 +09:00
Author: https://github.com/skyrising Commit: https://github.com/SerenityOS/serenity/commit/cac23820c5 Pull-request: https://github.com/SerenityOS/serenity/pull/23288 Reviewed-by: https://github.com/trflynn89
@ -8,7 +8,8 @@
|
||||
|
||||
AK::ByteString ak_byte_string_from_qstring(QString const& qstring)
|
||||
{
|
||||
return AK::ByteString(qstring.toUtf8().data());
|
||||
auto utf8_data = qstring.toUtf8();
|
||||
return AK::ByteString(utf8_data.data(), utf8_data.size());
|
||||
}
|
||||
|
||||
String ak_string_from_qstring(QString const& qstring)
|
||||
@ -24,10 +25,11 @@ QString qstring_from_ak_string(StringView ak_string)
|
||||
|
||||
AK::URL ak_url_from_qstring(QString const& qstring)
|
||||
{
|
||||
return AK::URL(qstring.toUtf8().data());
|
||||
auto utf8_data = qstring.toUtf8();
|
||||
return AK::URL(StringView(utf8_data.data(), utf8_data.size()));
|
||||
}
|
||||
|
||||
AK::URL ak_url_from_qurl(QUrl const& qurl)
|
||||
{
|
||||
return AK::URL(qurl.toString().toUtf8().data());
|
||||
return ak_url_from_qstring(qurl.toString());
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user