LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-16 00:40:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

UI/Qt: Update placeholder text if search disabled

Browse Source 
The placeholder text is there to prompt the user as to what could be
added in the address bar. The current text tells the user that they can
"Search or enter web address" even when the search setting is disabled.
When attempting to "Search" the user is instead sent to page ":", with
an error in the console:
    WebContent(575249): (FIXME) Don't know how to navigate to :

This patch fixes this by checking whether the search feature is enabled
and setting the placeholder appropriately. This provides a slightly
better user experience.

Closes #132
This commit is contained in:
Hugh Davenport 2024-06-10 13:43:50 +12:00 committed by Andreas Kling
parent 54183b8eef
commit cb657a038f
Notes: sideshowbarker 2024-07-19 16:48:57 +09:00 
Author: https://github.com/hughdavenport 🔰
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cb657a038f0
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/133
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Ladybird/Qt/LocationEdit.cpp
View File

@ -19,7 +19,10 @@ namespace Ladybird {
LocationEdit::LocationEdit(QWidget* parent)
: QLineEdit(parent)
{
setPlaceholderText("Search or enter web address");
if (Settings::the()->enable_search())
setPlaceholderText("Search or enter web address");
else
setPlaceholderText("Enter web address");
m_autocomplete = make<AutoComplete>(this);
this->setCompleter(m_autocomplete);