LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Tweak the color used for hovered media controls

Browse Source 
The link color is what closely resembled the color I was going for on
the machine I originally developed the controls on. But turns out this
is a very dark blue on most Serenity themes. Instead, hard-code the
original intended color, which is a lighter blue.
This commit is contained in:
Timothy Flynn 2023-04-10 11:34:29 -04:00 committed by Linus Groh
parent 59848086ba
commit cdf4c410bf
Notes: sideshowbarker 2024-07-16 21:36:44 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/cdf4c410bf
Pull-request: https://github.com/SerenityOS/serenity/pull/18281
Reviewed-by: https://github.com/linusg
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp
View File

@ -17,13 +17,14 @@
namespace Web::Painting {
static constexpr auto control_box_color = Gfx::Color::from_rgb(0x262626);
static constexpr auto control_box_color = Gfx::Color::from_rgb(0x26'26'26);
static constexpr auto control_highlight_color = Gfx::Color::from_rgb(0x1d'99'f3);
static Gfx::Color control_button_color(PaintContext& context, bool is_hovered)
static constexpr Gfx::Color control_button_color(bool is_hovered)
{
if (!is_hovered)
return Gfx::Color::from_rgb(0xff'ff'ff);
return context.palette().link();
return Color::White;
return control_highlight_color;
}
JS::NonnullGCPtr<VideoPaintable> VideoPaintable::create(Layout::VideoBox const& layout_box)
@ -114,7 +115,7 @@ void VideoPaintable::paint_loaded_video_controls(PaintContext& context, HTML::HT
};
auto playback_button_is_hovered = mouse_position.has_value() && playback_button_hover_rect.contains(*mouse_position);
auto playback_button_color = control_button_color(context, playback_button_is_hovered);
auto playback_button_color = control_button_color(playback_button_is_hovered);
if (is_paused) {
Array<Gfx::IntPoint, 3> play_button_coordinates { {
@ -170,7 +171,7 @@ void VideoPaintable::paint_placeholder_video_controls(PaintContext& context, Dev
} };
auto playback_button_is_hovered = mouse_position.has_value() && control_box_rect.contains(*mouse_position);
auto playback_button_color = control_button_color(context, playback_button_is_hovered);
auto playback_button_color = control_button_color(playback_button_is_hovered);
Gfx::AntiAliasingPainter painter { context.painter() };
painter.fill_ellipse(control_box_rect.to_type<int>(), control_box_color);