LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Scroll to the top after navigating to a new document

Browse Source 
This change fixes a bug with running tests where, if one of the
previous tests changes the scroll position, all subsequent tests that
rely on the scroll position will fail. This is because the headless
browser never resets the viewport offset.
This commit is contained in:
Aliaksandr Kalenik 2023-12-20 14:01:44 +01:00 committed by Andrew Kaster
parent 41b065dec9
commit cfcec5e18e
Notes: sideshowbarker 2024-07-16 22:16:50 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/cfcec5e18e
Pull-request: https://github.com/SerenityOS/serenity/pull/22367
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/Document.cpp
View File

@ -3578,6 +3578,11 @@ void Document::update_for_history_step_application(JS::NonnullGCPtr<HTML::Sessio
// 6. If documentIsNew is true, then: // 6. If documentIsNew is true, then:
if (document_is_new) { if (document_is_new) {
// FIXME: 1. Try to scroll to the fragment for document. // FIXME: 1. Try to scroll to the fragment for document.
// FIXME: According to the spec we should only scroll here if document has no parser or parsing has stopped.
// It should be ok to remove this after we implement navigation events and scrolling will happen in
// "process scroll behavior".
scroll_to_the_fragment();
// FIXME: 2. At this point scripts may run for the newly-created document document. // FIXME: 2. At this point scripts may run for the newly-created document document.
} }