From d1ffdd88b6ce982445eb7942ca9a57f37ec56bf8 Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sun, 3 Apr 2022 15:47:55 -0700 Subject: [PATCH] Meta: Sort PVS Studio suppressions numerically :^) --- .github/workflows/pvs-studio-static-analysis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pvs-studio-static-analysis.yml b/.github/workflows/pvs-studio-static-analysis.yml index 5b9f84e5a0d..e6a27fb02e0 100644 --- a/.github/workflows/pvs-studio-static-analysis.yml +++ b/.github/workflows/pvs-studio-static-analysis.yml @@ -100,19 +100,19 @@ jobs: run: pvs-studio-analyzer analyze -o project.plog --compiler ${{ env.PVS_STUDIO_ANALYSIS_ARCH }}-pc-serenity-g++ --compiler ${{ env.PVS_STUDIO_ANALYSIS_ARCH }}-pc-serenity-gcc -j2 # Suppress Rules: + # - TRY(..) macro breaks this rule: V530 The return value of function 'release_value' is required to be utilized. # - We are the system headers: V677 Custom declaration of a standard '' type. The declaration from system header files should be used instead. # - We have no choice: V1061 Extending the 'std' namespace may result in undefined behavior. - # - TRY(..) macro breaks this rule: V530 The return value of function 'release_value' is required to be utilized. # - False positives: - # V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference. - # V1076 Code contains invisible characters that may alter its logic. # V591 Non-void function should return a value. # V603 Object was created but is not being used. + # V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference. + # V1076 Code contains invisible characters that may alter its logic. # - name: Filter PVS Log working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }} run: | - pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 -v591 -v603 project.plog + pvs-studio-analyzer suppress -v530 -v591 -v603 -v677 -v1047 -v1061 -v1076 project.plog pvs-studio-analyzer filter-suppressed project.plog - name: Print PVS Log