mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-08-17 01:10:28 +03:00
CI: Prevent false errors if a commit message contains CRLF
Previously if a commit message contained any carriage returns it would correctly fail the 'contains CRLF line breaks' test, but it would also report 'Commit message lines are too long' and 'Commit title ends in a period', even if neither is true.
This commit is contained in:
parent
8d6d39e07c
commit
d2ef8b29e8
Notes:
sideshowbarker
2024-07-18 00:59:53 +09:00
Author: https://github.com/thislooksfun Commit: https://github.com/SerenityOS/serenity/commit/d2ef8b29e8b Pull-request: https://github.com/SerenityOS/serenity/pull/10954 Reviewed-by: https://github.com/IdanHo ✅
4
.github/workflows/lintcommits.yml
vendored
4
.github/workflows/lintcommits.yml
vendored
@ -20,7 +20,7 @@ jobs:
|
||||
error: "Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)",
|
||||
},
|
||||
{
|
||||
pattern: /^.{0,72}(?:\n(?:(.{0,72})|(.*?([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&/=]|-)+).*?))*$/,
|
||||
pattern: /^.{0,72}(?:\r?\n(?:(.{0,72})|(.*?([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&/=]|-)+).*?))*$/,
|
||||
error: "Commit message lines are too long (maximum allowed is 72 characters, except for URLs)",
|
||||
},
|
||||
{
|
||||
@ -32,7 +32,7 @@ jobs:
|
||||
error: "First word of commit after the subsystem is not capitalized",
|
||||
},
|
||||
{
|
||||
pattern: /^.+[^.\n](\n.*)*$/,
|
||||
pattern: /^.+[^.\n](\r?\n.*)*$/,
|
||||
error: "Commit title ends in a period",
|
||||
},
|
||||
{
|
||||
|
Loading…
Reference in New Issue
Block a user