LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't update input text if Ctrl or Alt are pressed

Browse Source 
With this change, input elements ignore keypresses while Ctrl or Alt
are pressed. This matches the behavior of Chrome and Firefox
This commit is contained in:
Tim Ledbetter 2024-01-30 20:09:33 +00:00 committed by Tim Flynn
parent 0d3072bdac
commit d73979e0a8
Notes: sideshowbarker 2024-07-17 05:19:06 +09:00 
Author: https://github.com/tcl3
Commit: https://github.com/SerenityOS/serenity/commit/d73979e0a8
Pull-request: https://github.com/SerenityOS/serenity/pull/23022
Reviewed-by: https://github.com/trflynn89 ✅
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View File

@ -689,10 +689,12 @@ bool EventHandler::focus_previous_element()
return element;
}
constexpr bool should_ignore_keydown_event(u32 code_point)
constexpr bool should_ignore_keydown_event(u32 code_point, u32 modifiers)
{
if (modifiers & (KeyModifier::Mod_Ctrl | KeyModifier::Mod_Alt))
return true;
// FIXME: There are probably also keys with non-zero code points that should be filtered out.
// FIXME: We should take the modifier keys into consideration somehow. This treats "Ctrl+C" as just "c".
return code_point == 0 || code_point == 27;
}
@ -755,7 +757,8 @@ bool EventHandler::handle_keydown(KeyCode key, u32 modifiers, u32 code_point)
m_edit_event_handler->handle_delete(*range);
return true;
}
if (!should_ignore_keydown_event(code_point)) {
// FIXME: Text editing shortcut keys (copy/paste etc.) should be handled here.
if (!should_ignore_keydown_event(code_point, modifiers)) {
m_edit_event_handler->handle_delete(*range);
m_edit_event_handler->handle_insert(JS::NonnullGCPtr { *m_browsing_context->cursor_position() }, code_point);
m_browsing_context->increment_cursor_position_offset();
@ -818,7 +821,8 @@ bool EventHandler::handle_keydown(KeyCode key, u32 modifiers, u32 code_point)
input_element.commit_pending_changes();
return true;
}
if (!should_ignore_keydown_event(code_point)) {
// FIXME: Text editing shortcut keys (copy/paste etc.) should be handled here.
if (!should_ignore_keydown_event(code_point, modifiers)) {
m_edit_event_handler->handle_insert(JS::NonnullGCPtr { *m_browsing_context->cursor_position() }, code_point);
m_browsing_context->increment_cursor_position_offset();
return true;