LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 10:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Do nothing when pressing modifier keys in HTML contenteditable

Browse Source 
Before this patch, pressing modifier keys such as Ctrl would insert
whitespace into editable DOM nodes. This patch crudely fixes that
behavior by checking if the codepoint associated with the event is
non-zero.
This commit is contained in:
Max Wipfli 2021-05-18 13:13:58 +02:00 committed by Andreas Kling
parent 157f72e9d7
commit d7df6de6a6
Notes: sideshowbarker 2024-07-18 17:36:19 +09:00 
Author: https://github.com/MaxWipfli
Commit: https://github.com/SerenityOS/serenity/commit/d7df6de6a6e
Pull-request: https://github.com/SerenityOS/serenity/pull/7268
Issue: https://github.com/SerenityOS/serenity/issues/7182
Issue: https://github.com/SerenityOS/serenity/issues/7202
Reviewed-by: https://github.com/Dexesttp
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View File

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -378,6 +379,12 @@ bool EventHandler::focus_previous_element()
return false;
}
constexpr bool should_ignore_keydown_event(u32 codepoint)
{
// FIXME: There are probably also keys with non-zero codepoints that should be filtered out.
return codepoint == 0;
}
bool EventHandler::handle_keydown(KeyCode key, unsigned modifiers, u32 code_point)
{
if (key == KeyCode::Key_Tab) {
@ -396,10 +403,9 @@ bool EventHandler::handle_keydown(KeyCode key, unsigned modifiers, u32 code_poin
m_frame.set_cursor_position({ *range->start_container(), range->start_offset() });
if (key == KeyCode::Key_Backspace || key == KeyCode::Key_Delete) {
m_edit_event_handler->handle_delete(range);
return true;
} else {
} else if (!should_ignore_keydown_event(code_point)) {
m_edit_event_handler->handle_delete(range);
m_edit_event_handler->handle_insert(m_frame.cursor_position(), code_point);
@ -465,13 +471,15 @@ bool EventHandler::handle_keydown(KeyCode key, unsigned modifiers, u32 code_poin
m_frame.set_cursor_position(move(new_position));
return true;
} else {
} else if (!should_ignore_keydown_event(code_point)) {
m_edit_event_handler->handle_insert(m_frame.cursor_position(), code_point);
auto new_position = m_frame.cursor_position();
new_position.set_offset(new_position.offset() + 1);
m_frame.set_cursor_position(move(new_position));
return true;
} else {
// NOTE: Because modifier keys should be ignored, we need to return true.
return true;
}
}